RHIDP-7614: Displaying the preferred username and Company Logo #1254
+154
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagak
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1254/ @ 08/08/25 13:43:49 |
debsmita1
reviewed
Jul 3, 2025
...es/configuring-the-global-header/proc-displaying-preferred-username-in-profile-dropdown.adoc
Outdated
Show resolved
Hide resolved
|
@its-mitesh-kumar to review the compant logo |
|
profile display name LGTM ! |
jmagak
force-pushed
the
RHIDP-7614-Global-Header-Add-Company-Logo-and-User-profile-icon-support
branch
from
5997a85 to
1a6ae62
Compare
jmagak
force-pushed
the
RHIDP-7614-Global-Header-Add-Company-Logo-and-User-profile-icon-support
branch
from
1a6ae62 to
2bc3691
Compare
…d-User-profile-icon-support
pabel-rh
reviewed
Aug 6, 2025
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Outdated
Show resolved
Hide resolved
...es/configuring-the-global-header/proc-displaying-preferred-username-in-profile-dropdown.adoc
Outdated
Show resolved
Hide resolved
…d-User-profile-icon-support
pabel-rh
approved these changes
Aug 11, 2025
|
@jmagak Also we need to add some documentation on how user can now enable the logo in sidebar. |
|
|
||
| The `CompanyLogo` supports strict display constraints to ensure visual consistency: | ||
|
|
||
| * Maximum dimensions: 150px wide, 40px high. |
There was a problem hiding this comment.
Now width and height can be provided through the configuration.
There was a problem hiding this comment.
Please Refer PR redhat-developer/rhdh-plugins#1068
| * The logo must retain its original proportions. | ||
| * The component layout remains fixed and cannot be moved from its mount point. | ||
| * Supports the following props: | ||
| ** `logo`: Encoded logo image. |
There was a problem hiding this comment.
Now theme-specific logo can be provided through configuration.
redhat-developer/rhdh#3023
|
|
||
| The `CompanyLogo` supports strict display constraints to ensure visual consistency: | ||
|
|
||
| * Maximum dimensions: 150px wide, 40px high. |
There was a problem hiding this comment.
Suggested change
| * Maximum dimensions: 150px wide, 40px high. | |
| * Default dimensions: | |
| - Width: 150px | |
| - Maximum Height: 40px | |
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Show resolved
Hide resolved
| * The default maximum dimensions: `150px` wide, `40px` high. | ||
| * The logo must retain its original proportions using `object-fit: contain`. | ||
| * The component keeps its layout fixed and you cannot move it from its mount point. | ||
| * `CompanyLogo` automatically scales the image down if dimensions exceed allowed size. |
There was a problem hiding this comment.
Instead of this maybe below points make more sense
- The image is never cropped or distorted.
- If the configured width would result in a height greater than the allowed maximum (default: 40px), it is automatically scaled down.
- This means: in some cases, changing only the width may not visibly affect the logo unless height is also adjusted.
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-displaying-company-logo-in-the-global-header.adoc
Show resolved
Hide resolved
| dark: 'data:image/svg+xml;base64,...' | ||
| ---- | ||
| + | ||
| `CompanyLogo` uses the following configuration elements to control fallback and sizing behavior: |
There was a problem hiding this comment.
You can take help of https://github.com/redhat-developer/rhdh-plugins/blob/main/workspaces/global-header/README.md#fallback-behavior to complete this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.7, main
Issue: RHIDP-7614
Preview:
7.3. Displaying company logo in the global header
7.4. Displaying the preferred username in the profile dropdown