RHDHBUGS-2070 - Added oc-mirror prerequisite #1430
Conversation
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1430/ @ 10/09/25 12:02:29 |
themr0c
added
Peer review needed 📖
Technical review needed 🔩
|
@themr0c looking at the preview under: but then later say: we should up Change the procedure callouts from "(Optional)" to "(Recommended)" to match the prerequisites. This maintains consistency and reinforces that while users can skip it, they shouldn't for OpenShift environments because using oc-mirror is the recommended way for mirroring on regular OpenShift clusters. wdyt? |
modules/installation/proc-install-rhdh-operator-airgapped-full.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-full.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-full.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
|
@Fortune-Ndlovu I believe I adressed all your suggestions. I made some additional changes to prepare for the AEM migration and simplify some steps that seemed unnecessarly complex. Can you have another round of review? |
modules/installation/proc-install-rhdh-operator-airgapped-full.adoc
Outdated
Show resolved
Hide resolved
….adoc Co-authored-by: Armel Soro <[email protected]>
|
I am aware that we will have to update the procedure for oc-mirror v2. See https://issues.redhat.com/browse/RHDHBUGS-2062 |
themr0c
added
Technical review done ⛅
|
/cherry-pick release-1.7 |
|
@themr0c: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
modules/installation/proc-install-rhdh-helm-airgapped-full.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-helm-airgapped-partial.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-full.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-full.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-partial.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-partial.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-partial.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-partial.adoc
Outdated
Show resolved
Hide resolved
modules/installation/proc-install-rhdh-operator-airgapped-partial.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Judith Magak <[email protected]>
|
New changes are detected. LGTM label has been removed. |
themr0c
added
Peer review done 📘
Ready to merge 💂
and removed
Peer review needed 📖
labels
|
@themr0c: new pull request created: #1436 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: Armel Soro <[email protected]> Co-authored-by: Judith Magak <[email protected]>
Co-authored-by: Armel Soro <[email protected]> Co-authored-by: Judith Magak <[email protected]>
6 participants
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): release-1.7, 1.8
Issue: https://issues.redhat.com/browse/RHDHBUGS-2070
Preview: