Skip to content

Conversation

@pabel-rh
Copy link
Member

@pabel-rh pabel-rh commented Nov 3, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
1.8.0, main
Issue:
RHDHPAI-1089
Preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1478/openshift-ai-connector-for-rhdh/

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 3, 2025

Copy link

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of minor items @pabel-rh

Copy link

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of items @pabel-rh .... think we are about there - THANKS !!

Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for your consideration, @pabel-rh.

Copy link

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @pabel-rh @benwilcock these suggestions/review stems from Ben's review in the google doc and the group slack convo the 3 of us had

Copy link

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @pabel-rh

thanks for all your hard work !!

@benwilcock FYI

@pabel-rh pabel-rh added Technical review done ⛅ Any procedure has been succesfully tested Ready to merge 💂 and removed do-no-merge/review-in-progress 👀 Technical review needed 🔩 Test all the procedures labels Nov 7, 2025
@jmagak
Copy link
Member

jmagak commented Nov 7, 2025

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit afa801e into redhat-developer:main Nov 7, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@jmagak: new pull request created: #1525

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants