Rhidp 9758: Enable GitLab authentication#1839
Rhidp 9758: Enable GitLab authentication#1839themr0c merged 27 commits intoredhat-developer:mainfrom
Conversation
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1839/ @ 03/05/26 12:25:44 |
pabel-rh
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
JessicaJHee
left a comment
JessicaJHee
left a comment
There was a problem hiding this comment.
Thanks for this contribution! A few changes are needed, and @albarbaro will be reviewing the GitLab auth app set up
modules/authentication/snip-enable-user-authentication-with-gitlab-common-first-steps.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/snip-enable-user-authentication-with-gitlab-common-first-steps.adoc
Outdated
Show resolved
Hide resolved
albarbaro
left a comment
albarbaro
left a comment
There was a problem hiding this comment.
I don't see the integrations configuration part mentioned anywhere: as stated in the upstream docs (and it should be also in the notes docs I have provided with the Jira Feature) the integration set up is required to provide authenticated requests to Gitlab and avoid anonymous one. To set the integration for authenticated requests , creating a token is a prerequisite (upstream docs). The rest look good to me.
modules/authentication/snip-enable-user-authentication-with-gitlab-common-first-steps.adoc
Outdated
Show resolved
Hide resolved
albarbaro
left a comment
albarbaro
left a comment
There was a problem hiding this comment.
Looks good to me now. Thanks!
pabel-rh
added
Technical review done ⛅
pabel-rh
added
Peer review needed 📖
and removed
Technical review done ⛅
…ub (redhat-developer#1810) Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
…(RHDHBUGS-2614); also add a reminder note about this needing to be regenerated in future as more plugins move to OCI (redhat-developer#1782) * chore: add migration tables to the install guide for dynamic plugins (RHDHBUGS-2614); also add a reminder note about this needing to be regenerated in future as more plugins move to OCI Signed-off-by: Nick Boldt <nboldt@redhat.com> * fix compilation errors Signed-off-by: Nick Boldt <nboldt@redhat.com> * regen from latest Signed-off-by: Nick Boldt <nboldt@redhat.com> * provide error/warning when path is empty (no wrapper found, so no OCI ref provided) Signed-off-by: Nick Boldt <nboldt@redhat.com> * reordered content per Gerry's suggestion Signed-off-by: Nick Boldt <nboldt@redhat.com> * fix logic for determining if plugins are enabled by default (including orchestrator, which are NOT) Signed-off-by: Nick Boldt <nboldt@redhat.com> * fix the missing oci refs Signed-off-by: Nick Boldt <nboldt@redhat.com> * generate adoc and csv Signed-off-by: Nick Boldt <nboldt@redhat.com> * regen header in ref-community-plugins-migration.adoc based on changes made to the template Signed-off-by: Nick Boldt <nboldt@redhat.com> --------- Signed-off-by: Nick Boldt <nboldt@redhat.com>
|
themr0c
added
Technical review done ⛅
|
/cherry-pick release-1.9 |
|
@themr0c: new pull request created: #1871 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9 participants
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
main, 1.9
Issue:
https://issues.redhat.com/browse/RHIDP-9758
Preview:
Created a similar PR from #1798 to make updates in Jana's absence