Skip to content

Open requested system packages for javac #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rgrunber merged 1 commit into from
Dec 30, 2024
Merged

Open requested system packages for javac #3902

rgrunber merged 1 commit into from
Dec 30, 2024

Conversation

@snjeza
Copy link
Collaborator

@snjeza snjeza commented Dec 20, 2024

mickaelistria
mickaelistria reviewed Dec 20, 2024
View reviewed changes
src/javaServerStarter.ts
'--add-opens',
'java.base/java.nio.channels=ALL-UNNAMED',
'--add-opens',
'java.base/sun.nio.ch=ALL-UNNAMED',
Copy link
Contributor

@mickaelistria mickaelistria Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another one is freshly necessary: --add-opens java.compiler/javax.tools=ALL-UNNAMED. Note that the exact list is available in the org.eclipse.jdt.core.javac/META-INF/p2.inf` file and should be part of the .ini file generated with the JDT-LS product.
Ideally, instead of hardcoding/duplicating those here, they should be read from one of the upstream files.

@snjeza
Copy link
Collaborator Author

snjeza commented Dec 20, 2024

another one is freshly necessary: --add-opens java.compiler/javax.tools=ALL-UNNAMED. Note that the exact list is available in the org.eclipse.jdt.core.javac/META-INF/p2.inf` file and should be part of the .ini file generated with the JDT-LS product.

I have added it - 4f51d5c#diff-2d9ec606b265a83596a734df153c4ef01523700dc2576dcf1a80c9092c14d6d3R143

@mickaelistria
Copy link
Contributor

mickaelistria commented Dec 20, 2024

Good to be merged ASAP IMO

@rgrunber
Copy link
Member

rgrunber commented Dec 30, 2024

@snjeza , if you have time, I would also update https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/1d41ddee3b461fcd8b30eadb3d7dd6abf56814ed/pom.xml#L343 .

@rgrunber rgrunber merged commit 266537c into redhat-developer:master Dec 30, 2024
2 checks passed
@snjeza snjeza mentioned this pull request Dec 30, 2024
Merged
@snjeza
Copy link
Collaborator Author

snjeza commented Dec 30, 2024

if you have time, I would also update https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/1d41ddee3b461fcd8b30eadb3d7dd6abf56814ed/pom.xml#L343 .

@rgrunber Please check eclipse-jdtls/eclipse.jdt.ls#3351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fbricon fbricon Awaiting requested review from fbricon

@rgrunber rgrunber Awaiting requested review from rgrunber

@testforstephen testforstephen Awaiting requested review from testforstephen

1 more reviewer

@mickaelistria mickaelistria mickaelistria left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snjeza @mickaelistria @rgrunber