Skip to content

Open requested system packages for javac #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrunber merged 1 commit into from
Dec 30, 2024
Merged

Open requested system packages for javac #3902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/javaServerStarter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,16 @@ function prepareParams(requirements: RequirementsData, workspacePath, context: E
'jdk.compiler/com.sun.tools.javac.platform=ALL-UNNAMED',
'--add-opens',
'jdk.compiler/com.sun.tools.javac.resources=ALL-UNNAMED',
'--add-opens',
'jdk.compiler/com.sun.tools.javac.jvm=ALL-UNNAMED',
'--add-opens',
'jdk.zipfs/jdk.nio.zipfs=ALL-UNNAMED',
'--add-opens',
'java.compiler/javax.tools=ALL-UNNAMED',
'--add-opens',
'java.base/java.nio.channels=ALL-UNNAMED',
'--add-opens',
'java.base/sun.nio.ch=ALL-UNNAMED',
Copy link
Contributor

@mickaelistria mickaelistria Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another one is freshly necessary: --add-opens java.compiler/javax.tools=ALL-UNNAMED. Note that the exact list is available in the org.eclipse.jdt.core.javac/META-INF/p2.inf` file and should be part of the .ini file generated with the JDT-LS product.
Ideally, instead of hardcoding/duplicating those here, they should be read from one of the upstream files.

'-DICompilationUnitResolver=org.eclipse.jdt.core.dom.JavacCompilationUnitResolver',
'-DCompilationUnit.DOM_BASED_OPERATIONS=true',
'-DAbstractImageBuilder.compilerFactory=org.eclipse.jdt.internal.javac.JavacCompilerFactory'
Expand Down
Loading