fix: optimize existsById() to use Redis EXISTS command instead of dat… #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a retrieval (redis#657) The existsById() method in both RedisDocumentRepository and RedisEnhancedRepository was inefficiently retrieving entire data structures when only existence validation was needed. This optimization replaces the inherited Spring Data behavior with direct Redis EXISTS commands, providing significant performance gains. Changes: - Override existsById() in SimpleRedisDocumentRepository and SimpleRedisEnhancedRepository - Use connection.keyCommands().exists() for O(1) existence checks - Properly handle composite IDs by implementing getKeyForId() helper methods - Apply ID filters and maintain full backward compatibility Performance impact: - Documents: existsById() → findById() → JSON.GET → full document deserialization - Hashes: existsById() → findById() → HGETALL → full hash retrieval - After: existsById() → EXISTS → boolean result only - Eliminates unnecessary network transfer and CPU overhead for existence checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a retrieval (#657)
The existsById() method in both RedisDocumentRepository and RedisEnhancedRepository was inefficiently retrieving entire data structures when only existence validation was needed. This optimization replaces the inherited Spring Data behavior with direct Redis EXISTS commands, providing significant performance gains.
Changes:
Performance impact: