Skip to content

fix: optimize existsById() to use Redis EXISTS command instead of dat… #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

fix: optimize existsById() to use Redis EXISTS command instead of dat… #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions ...g/src/main/java/com/redis/om/spring/repository/support/SimpleRedisDocumentRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.springframework.data.keyvalue.core.KeyValueOperations;
import org.springframework.data.keyvalue.core.mapping.KeyValuePersistentEntity;
import org.springframework.data.keyvalue.repository.support.SimpleKeyValueRepository;
import org.springframework.data.redis.core.RedisCallback;
import org.springframework.data.redis.core.RedisTemplate;
import org.springframework.data.redis.core.TimeToLive;
import org.springframework.data.redis.core.convert.KeyspaceConfiguration;
Expand Down Expand Up @@ -722,6 +723,50 @@ public <S extends T> boolean exists(Example<S> example) {
return count(example) > 0;
}

@Override
public boolean existsById(ID id) {
Assert.notNull(id, "The given id must not be null");

// Use direct Jedis EXISTS command for optimal performance
// Construct key properly for composite IDs
String fullKey = getKeyForId(id);

return Boolean.TRUE.equals(modulesOperations.template().execute((RedisCallback<Boolean>) connection -> connection
.keyCommands().exists(fullKey.getBytes())));
}

private String getKeyForId(Object id) {
// Get the mapping context's entity info
RedisEnhancedPersistentEntity<?> persistentEntity = (RedisEnhancedPersistentEntity<?>) mappingContext
.getRequiredPersistentEntity(metadata.getJavaType());

String stringId;

// Handle composite IDs
if (persistentEntity.isIdClassComposite()) {
BeanWrapper wrapper = new DirectFieldAccessFallbackBeanWrapper(id);
List<String> idParts = new ArrayList<>();
for (RedisPersistentProperty idProperty : persistentEntity.getIdProperties()) {
Object propertyValue = wrapper.getPropertyValue(idProperty.getName());
if (propertyValue != null) {
idParts.add(propertyValue.toString());
}
}
stringId = String.join(":", idParts);
} else {
stringId = mappingConverter.getConversionService().convert(id, String.class);
}

// Apply ID filters if they exist
var maybeIdentifierFilter = indexer.getIdentifierFilterFor(metadata.getJavaType());
if (maybeIdentifierFilter.isPresent()) {
IdentifierFilter<String> filter = (IdentifierFilter<String>) maybeIdentifierFilter.get();
stringId = filter.filter(stringId);
}

return getKeyspace() + stringId;
}

// -------------------------------------------------------------------------
// Query By Example Fluent API - QueryByExampleExecutor
// -------------------------------------------------------------------------
Expand Down
45 changes: 45 additions & 0 deletions ...g/src/main/java/com/redis/om/spring/repository/support/SimpleRedisEnhancedRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.springframework.data.keyvalue.core.mapping.KeyValuePersistentEntity;
import org.springframework.data.keyvalue.repository.support.SimpleKeyValueRepository;
import org.springframework.data.redis.core.PartialUpdate;
import org.springframework.data.redis.core.RedisCallback;
import org.springframework.data.redis.core.RedisTemplate;
import org.springframework.data.redis.core.convert.RedisData;
import org.springframework.data.redis.core.convert.ReferenceResolverImpl;
Expand Down Expand Up @@ -596,6 +597,50 @@ public <S extends T> boolean exists(Example<S> example) {
return count(example) > 0;
}

@Override
public boolean existsById(ID id) {
Assert.notNull(id, "The given id must not be null");

// Use direct Jedis EXISTS command for optimal performance
// Construct key properly for composite IDs
String fullKey = getKeyForId(id);

return Boolean.TRUE.equals(modulesOperations.template().execute((RedisCallback<Boolean>) connection -> connection
.keyCommands().exists(fullKey.getBytes())));
}

private String getKeyForId(Object id) {
// Get the mapping context's entity info
RedisEnhancedPersistentEntity<?> persistentEntity = (RedisEnhancedPersistentEntity<?>) mappingConverter
.getMappingContext().getRequiredPersistentEntity(metadata.getJavaType());

String stringId;

// Handle composite IDs
if (persistentEntity.isIdClassComposite()) {
BeanWrapper wrapper = new DirectFieldAccessFallbackBeanWrapper(id);
List<String> idParts = new ArrayList<>();
for (RedisPersistentProperty idProperty : persistentEntity.getIdProperties()) {
Object propertyValue = wrapper.getPropertyValue(idProperty.getName());
if (propertyValue != null) {
idParts.add(propertyValue.toString());
}
}
stringId = String.join(":", idParts);
} else {
stringId = mappingConverter.getConversionService().convert(id, String.class);
}

// Apply ID filters if they exist
var maybeIdentifierFilter = indexer.getIdentifierFilterFor(metadata.getJavaType());
if (maybeIdentifierFilter.isPresent()) {
IdentifierFilter<String> filter = (IdentifierFilter<String>) maybeIdentifierFilter.get();
stringId = filter.filter(stringId);
}

return getKeyspace() + stringId;
}

// -------------------------------------------------------------------------
// Query By Example Fluent API - QueryByExampleExecutor
// -------------------------------------------------------------------------
Expand Down