Skip to content

feat(MCP): Add upsert-records tool to RedisVL MCP#540

Open
vishal-bala wants to merge 4 commits intofeat/RAAE-1397/search-toolfrom
feat/RAAE-1398/upsert-tool
Open

feat(MCP): Add upsert-records tool to RedisVL MCP#540
vishal-bala wants to merge 4 commits intofeat/RAAE-1397/search-toolfrom
feat/RAAE-1398/upsert-tool

Conversation

@vishal-bala
Copy link
Collaborator

@vishal-bala vishal-bala commented Mar 25, 2026

Builds on top of #539

Note

Medium Risk
Adds a new MCP write path that validates, embeds, and persists records to Redis, which can affect data integrity and partial-write behavior. Scope is contained to a new tool with tests and is gated behind read_only mode.

Overview
Adds a new MCP tool, upsert-records, to insert/update documents in the configured Redis index, including request validation, optional server-side embedding generation (with async/sync/batch fallbacks), and HASH vector serialization prior to index.load().

Updates MCP server tool registration to include upsert-records only when not in read_only mode, and exports the new tool from redisvl.mcp.tools. Adds unit + integration coverage for success cases, validation failures (pre-write), embedding behavior (skip_embedding_if_present), and marking backend failures as partial_write_possible.

Separately adjusts MCP filter typing annotations to use typing.Union/List/Dict instead of newer syntax.

Written by Cursor Bugbot for commit 11f5d07. This will update automatically on new commits. Configure here.

@vishal-bala vishal-bala self-assigned this Mar 25, 2026
@vishal-bala vishal-bala added the auto:minor Increment the minor version when merged label Mar 25, 2026
@jit-ci
Copy link

jit-ci bot commented Mar 25, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@vishal-bala vishal-bala changed the title feat(MCP): Add tool for upserting records to the RedisVL MCP feat(MCP): Add upsert-records tool to RedisVL MCP Mar 25, 2026
@vishal-bala vishal-bala marked this pull request as ready for review March 25, 2026 16:53
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c748db2c6c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant