-
Notifications
You must be signed in to change notification settings - Fork 47
[25.3] Security report and other additions to What's New #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
IoannisRP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a minor comment, the security report sections look good 👍
bashtanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compaction improvement pushed out of 25.3.1, might be in future minor and Compaction improvement pushed out of 25.3.1, might be in future minor LGTM
IoannisRP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| NOTE: All concepts described in this section are compatible with Kafka and its client libraries and CLIs. This section does not cover ways you can protect your Redpanda cluster externally; for example, through network ACLs or private networks. | ||
| [NOTE] | ||
| ==== | ||
| All concepts described in this section are compatible with Kafka and its client libraries and CLIs. This section does not cover ways you can protect your Redpanda cluster externally; for example, through network ACLs or private networks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbatuigas I'm not sure this is accurate anymore technically since e.g. Schema Registry AuthZ isn't part of kafka and this whole section describes a bunch of stuff not part of kafka. I think we should just leave the second sentence and skip the first one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed first sentence from note
| All concepts described in this section are compatible with Kafka and its client libraries and CLIs. This section does not cover ways you can protect your Redpanda cluster externally; for example, through network ACLs or private networks. | ||
| Use the link:api/doc/admin/operation/operation-get_security_report[`/v1/security/report`] Admin API endpoint to generate a comprehensive security report for your cluster. This endpoint provides detailed information about TLS configuration, authentication methods, authorization status, and security alerts across all Redpanda interfaces (Kafka, RPC, Admin, Schema Registry, HTTP Proxy). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbatuigas having this in the info box at the top of the security section seems noisy and distracting to me. This is a very minor thing only for very advanced users. We should mention it but not let it steal the show.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved security report content out of note
| -- | ||
| ==== | ||
|
|
||
| NOTE: Use the link:api/doc/admin/operation/operation-get_security_report[`/v1/security/report`] endpoint to generate a comprehensive security report for your cluster. This endpoint provides detailed information about TLS configuration, authentication methods, authorization status, and security alerts across all Redpanda interfaces, including the Admin API itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbatuigas this also feels out of place. this section is about the format and style of the admin API, not about one particular minor feature enabled through it.
I think the best place to introduce the security report API is probably at the bottom of the 'Authentication' section of Security docs (since its mostly reporting on the AUthN status of all the endpoints). It's fine to also included in the PP / SR pages as you have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved security report content to Authentication
modules/deploy/pages/redpanda/manual/production/production-readiness.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| === Monitor security settings | ||
|
|
||
| Regularly review your cluster's security settings using the link:api/doc/admin/operation/operation-get_security_report[`/v1/security/report`] Admin API endpoint. Investigate and address any issues identified in the alerts section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is awaiting another PR to merge or something else, but this link gives a page not found error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link will work once redpanda-data/api-docs#35 is merged
Feediver1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
Co-authored-by: Joyce Fee <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
Description
Related (API docs) redpanda-data/api-docs#35
This pull request introduces documentation for a new Admin API endpoint,
/v1/security/report, which generates a comprehensive security report for Redpanda clusters. The changes add usage instructions, output examples, and highlight the endpoint’s ability to report on TLS, authentication, authorization, and security alerts across all Redpanda interfaces. The updates are made across multiple documentation files to ensure users are aware of this feature and know how to use it for monitoring and auditing cluster security.Security report endpoint documentation:
/v1/security/reportAdmin API endpoint in various documentation sections, including production readiness, authentication, HTTP Proxy, and Schema Registry. [1] [2] [3] [4]security-report.adoc, that provides a sample request and output for the security report endpoint, including details about interfaces and alerts for insecure configurations.Other documentation updates:
Resolves https://redpandadata.atlassian.net/browse/DOC-1763, https://redpandadata.atlassian.net/browse/DOC-1195, https://redpandadata.atlassian.net/browse/DOC-1594
Review deadline: 18 Nov
Page previews
Security Report:
Authentication > Generate security report
Use the Schema Registry API
Use Redpanda with HTTP Proxy API
Production Readiness Checklist (Level 1 and Level 3)
Security report, Topic IDs and Compaction in What's New: https://deploy-preview-1450--redpanda-docs-preview.netlify.app/25.3/get-started/release-notes/redpanda/#security-report
Updates to tombstone removal: https://deploy-preview-1450--redpanda-docs-preview.netlify.app/25.3/manage/cluster-maintenance/compaction-settings/#tombstone-record-removal
Checks