[connect] Add ServiceAccount-specific labels support#1718
Open
ystkfujii wants to merge 1 commit intoredpanda-data:mainfrom
Open
[connect] Add ServiceAccount-specific labels support#1718ystkfujii wants to merge 1 commit intoredpanda-data:mainfrom
ystkfujii wants to merge 1 commit intoredpanda-data:mainfrom
Conversation
ystkfujii
requested review from
RafalKorepta,
andrewstucki and
chrisseto
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows adding labels that apply only to the ServiceAccount via values.yaml.
While the chart already supports common labels using
{{ include "redpanda-connect.labels" . }}, those labels are applied to multiple resources such as Service and ConfigMap. This makes them unsuitable when labels are required specifically for the ServiceAccount.By introducing
serviceAccount.labels, users can now attach labels exclusively to the ServiceAccount without affecting other resources.A similar ServiceAccount-specific label configuration exists in other charts, such as Grafana:
https://github.com/grafana/helm-charts/blob/6665978af1eb54f27c389cdfaa2a01dca1f277c2/charts/grafana/templates/serviceaccount.yaml#L8