crash instantly on data loss errors

[nvartolomei]

crash instantly on data loss errors

We (@nvartolomei and @bash) found that GroupReadWorker wouldn't report
data loss. The reason is that we didn't fail the test instantly when
data loss is detected instead we relied on monotonicity validation to
fail. I.e. we would crash when we detected that we would consume an
earlier offset compared to what we consumed before.

In the GroupReadWorker we reset the monotonicity validation state on any
errors because the next attempt at consuming is almost certain to read
the second time offsets already consumed. As a result we wouldn't catch
monotonicity issues.

In retrospect, it would have been better to fail instantly when franz-go
detects data loss. So this commit achieves exactly that.

[dotnwat]

i realize this is draft i didn't intend to hit approve, but it also looked ok.

[bashtanov]

I suspect false positives on data loss in franz-go https://github.com/twmb/franz-go/blob/master/pkg/kgo/consumer.go#L2283, so I'll check with Travis.

[dotnwat]

I suspect false positives on data loss in franz-go https://github.com/twmb/franz-go/blob/master/pkg/kgo/consumer.go#L2283, so I'll check with Travis.

@bashtanov @nvartolomei what's the status on this pr?

[bashtanov]

Most probably the failures are not related to franz-go, so let's merge it

[dotnwat]

@nvartolomei ping

[nvartolomei]

There’s a failure in an upgrade test happening with an old version. Want to figure that one out to avoid introducing ci noise.

…

On Fri, 18 Oct 2024 at 22:09, Noah Watkins ***@***.***> wrote: @nvartolomei <https://github.com/nvartolomei> ping — Reply to this email directly, view it on GitHub <#56 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEETWMYCEIEBQQOJSBVLITZ4F2H3AVCNFSM6AAAAABP7AXDWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGIZTMMJTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>