charts/redpanda: allow overriding volumes #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
Previously it wasn't possible to use `podTemplate` to override the `VolumeSource`. Helm prevented explicitly null'ing out values due to the chart's schema and the go implementation has no concept of explicit nulls. This commit copies the precedent set in `mergeEnvVar` and simply elects the override if provided. Additionally this commit adds a test case showcasing how to use `podTemplate` to generate certificates from an initContainer. K8S-683
chrisseto
force-pushed
the
chris/p/redpanda-volume-overrides
branch
from
8226d2a to
08c55a9
Compare
RafalKorepta
approved these changes
Sep 9, 2025
Contributor
|
Does this close out this issue? redpanda-data/helm-charts#835 |
Contributor
Author
I don't believe so. This corrects some behavior when using certain podTemplate overrides and isn't really related to mTLS. Though #1071 might actually address that issue. There will still be some edges around how you enable mTLS but it should make the simple case work. |
This was referenced Sep 9, 2025
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wasn't possible to use
podTemplateto override theVolumeSource. Helm prevented explicitly null'ing out values due to the chart's schema and the go implementation has no concept of explicit nulls.This commit copies the precedent set in
mergeEnvVarand simply elects the override if provided.Additionally this commit adds a test case showcasing how to use
podTemplateto generate certificates from an initContainer.K8S-683