[release/v2.4.x] charts/redpanda: allow overriding volumes #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
andrewstucki,
chrisseto and
gene-redpanda
as code owners
Author
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
chrisseto
force-pushed
the
backport/release/v2.4.x/pr-1070
branch
from
5d72eed to
b489a4f
Compare
chrisseto
approved these changes
Sep 16, 2025
Previously it wasn't possible to use `podTemplate` to override the `VolumeSource`. Helm prevented explicitly null'ing out values due to the chart's schema and the go implementation has no concept of explicit nulls. This commit copies the precedent set in `mergeEnvVar` and simply elects the override if provided. Additionally this commit adds a test case showcasing how to use `podTemplate` to generate certificates from an initContainer. K8S-683 (cherry picked from commit 1f5dfc9) # Conflicts: # charts/redpanda/helpers_test.go
chrisseto
force-pushed
the
backport/release/v2.4.x/pr-1070
branch
from
b489a4f to
7e9e566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease/v2.4.x:Questions ?
Please refer to the Backport tool documentation