[release/v25.1.x] charts/redpanda: use new sidecar --selector flag #1174
Conversation
github-actions
bot
requested review from
RafalKorepta,
andrewstucki,
chrisseto and
gene-redpanda
as code owners
chrisseto
force-pushed
the
backport/release/v25.1.x/pr-1151
branch
2 times, most recently
from
59a2e18 to
f7d7883
Compare
| } | ||
| } | ||
|
|
||
| func removeAllFinalizers(ctx context.Context, t framework.TestingT, gvk schema.GroupVersionKind) { |
There was a problem hiding this comment.
This is unused as the upgrade tests are performed within a vCluster. (I'm pretty sure at least but I just noticed the isolated tag is missing in this branch)
| t.ApplyManifest(ctx, file.Name()) | ||
| } | ||
|
|
||
| func iKustomizeApply(ctx context.Context, t framework.TestingT, url string) { |
There was a problem hiding this comment.
This helper is net new to this commit. v25.2+ doesn't need to worry about it and the existing strategy of using the in repo CRDs felt kludgey.
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
RafalKorepta
force-pushed
the
backport/release/v25.1.x/pr-1151
branch
from
f7d7883 to
44abb4c
Compare
RafalKorepta
force-pushed
the
backport/release/v25.1.x/pr-1151
branch
from
44abb4c to
1296990
Compare
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
RafalKorepta
force-pushed
the
backport/release/v25.1.x/pr-1151
branch
3 times, most recently
from
f24631b to
fd80c5e
Compare
This commit builds upon a previous commit that added the `--selector` flag to the sidecar. It updates the chart to appropriate set this new flag and adds acceptance tests to assert the functionality works as expected. This commit is separate as the v2.x.x branches need to release the updated sidecar before it can be used. (cherry picked from commit 13aeda8)
RafalKorepta
force-pushed
the
backport/release/v25.1.x/pr-1151
branch
from
fd80c5e to
483be93
Compare
In the #1174 backport PR chart directory was copied from main branch, but template files was not moved in release/v25.1.x branch.
In the #1174 backport PR chart directory was copied from main branch, but template files was not moved in release/v25.1.x branch.
Backport
This will backport the following commits from
maintorelease/v25.1.x:Questions ?
Please refer to the Backport tool documentation