[K8S-535] charts/*: close values' schemas#555
Merged
Conversation
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
2 times, most recently
from
16fcc87 to
eb51999
Compare
Contributor
Author
|
Based on #556 |
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
3 times, most recently
from
e488083 to
61c4b7f
Compare
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
from
61c4b7f to
e03b720
Compare
RafalKorepta
approved these changes
Mar 25, 2025
Contributor
RafalKorepta
left a comment
RafalKorepta
left a comment
There was a problem hiding this comment.
LGTM. My PR just causes merge conflicts.
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
2 times, most recently
from
04f2249 to
ec66ce8
Compare
Contributor
|
Lint is failing |
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
2 times, most recently
from
97d1a05 to
67c9d17
Compare
Contributor
Author
|
This is now based on #575 |
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
2 times, most recently
from
7b61c23 to
34dcceb
Compare
Contributor
Author
|
And now also based on #577 :( |
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
from
34dcceb to
6745c6b
Compare
Prior to this commit our charts' schemas were "open" which allowed extraneous keys to be specified without repercussions. This had lead to many cases of users having values files that "didn't work" due to incorrect key names, indentation issues, etc. As we're pushing out new major releases with breaking changes along side core's 25.1 release, this commit "closes" the charts' schemas which catch any incompatible values or unexpected upgrades.
chrisseto
force-pushed
the
chris/p/charts-close-schemas
branch
from
6745c6b to
5a06707
Compare
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit our charts' schemas were "open" which allowed extraneous keys to be specified without repercussions. This had lead to many cases of users having values files that "didn't work" due to incorrect key names, indentation issues, etc.
As we're pushing out new major releases with breaking changes along side core's 25.1 release, this commit "closes" the charts' schemas which catch any incompatible values or unexpected upgrades.