Merged
Conversation
jan-g
requested review from
RafalKorepta,
andrewstucki,
chrisseto and
gene-redpanda
as code owners
Given the desire to merge the drift controller with the general cluster reconciler, we need to track the mock admin api state on a per-cluster basis - otherwise the rapid reassertion of state will cause flapping as the mock API is poked on behalf of multiple clusters.
jan-g
force-pushed
the
v1-unit-test-race-condition
branch
from
50399f8 to
6d718c2
Compare
Contributor
Author
|
There was one glitch to fix - the zero value of the MockAdminAPI struct isn't quite usable without calling |
Contributor
Author
|
What I don't fully understand is how/why we haven't seen more of these race conditions already - even with a separate drift controller, state should still be being reasserted. I think we were just really lucky, and a left-behind value from test A was viewed as an ad-hoc setting for test B, so didn't cause a reassertion of state (!) |
alenkacz
pushed a commit
that referenced
this pull request
Apr 7, 2025
Given the desire to merge the drift controller with the general cluster reconciler, we need to track the mock admin api state on a per-cluster basis - otherwise the rapid reassertion of state will cause flapping as the mock API is poked on behalf of multiple clusters.
RafalKorepta
pushed a commit
that referenced
this pull request
Apr 7, 2025
Given the desire to merge the drift controller with the general cluster reconciler, we need to track the mock admin api state on a per-cluster basis - otherwise the rapid reassertion of state will cause flapping as the mock API is poked on behalf of multiple clusters.
alenkacz
added a commit
that referenced
this pull request
Apr 8, 2025
* Testing: one MockAdminAPI per cluster (#561) Given the desire to merge the drift controller with the general cluster reconciler, we need to track the mock admin api state on a per-cluster basis - otherwise the rapid reassertion of state will cause flapping as the mock API is poked on behalf of multiple clusters. * V1 drop drift controller (#543) * Periodically cycle to reassert cluster configuration * Drop drift controller * Fix up unit test failures * Drop three-way merge code * Drop annotation copy in secret --------- Co-authored-by: jan grant <3430517+jan-g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the desire to merge the drift controller with the general cluster reconciler, we need to track the mock admin api state on a per-cluster basis - otherwise the rapid reassertion of state will cause flapping as the mock API is poked on behalf of multiple clusters.