-
Notifications
You must be signed in to change notification settings - Fork 707
shadowing: stop replicators on topic deletion #28825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where shadow replicators were not properly stopped when topics were deleted, causing runaway replicators. The fix adds logic to detect when topics are no longer being mirrored and stops their replicators during link configuration updates.
Key changes:
- Added reconciliation logic to stop replicators for deleted topics
- Improved observability by upgrading state-mutating request logs from trace to info level
- Enhanced status output consistency by sorting topics and partitions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/v/cluster_link/link.cc |
Adds tracking and cleanup of replicators for topics that are no longer being mirrored |
src/v/redpanda/admin/services/shadow_link/shadow_link.cc |
Moves logging of state-mutating requests from trace to info level for better observability |
src/v/redpanda/admin/services/shadow_link/converter.cc |
Sorts shadow topics and partition information in status output for consistent reporting |
tests/rptest/tests/cluster_linking_e2e_test.py |
Extends test coverage to verify replicators are properly stopped and can be restarted after topic deletion and re-creation |
CI test resultstest results on build#77284
test results on build#77301
test results on build#77348
|
|
/ci-repeat 1 |
Fixes the reconciliation logic to stop the replicators that are no longer needed.
.. for consistent output representation
1ccde65 to
9263bed
Compare
rockwotj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proto changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
|
/backport v25.3.x |
|
Failed to create a backport PR to v25.3.x branch. I tried: |
Fixes the reconciliation logic to stop the replicators that are no longer needed after topic got deleted.
Additionally
Fixes
Backports Required
Release Notes
Bug Fixes