Skip to content

fix: APP-406 email always required when buying with credit card#2580

Merged
blushi merged 3 commits intodevfrom
fix-APP-406-web3-credit-card
Jan 22, 2025
Merged

fix: APP-406 email always required when buying with credit card#2580
blushi merged 3 commits intodevfrom
fix-APP-406-web3-credit-card

Conversation

@blushi
Copy link
Member

@blushi blushi commented Jan 20, 2025

Description

https://regennetwork.atlassian.net/browse/APP-406


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

From https://deploy-preview-2580--regen-marketplace.netlify.app/project/mai-ndombe-4/buy
log in with a web3 account but choose to buy with credit card
Email field on the "Payment info" step should be required.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit e552a7d
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6790b8f5d8be650008083649
😎 Deploy Preview https://deploy-preview-2580--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit e552a7d
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/6790b8f56ed6870008ab175a
😎 Deploy Preview https://deploy-preview-2580--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested a review from r41ph January 20, 2025 13:15
@blushi
Copy link
Member Author

blushi commented Jan 20, 2025

@erikalogie @S4mmyb see testing instructions

@erikalogie
Copy link
Collaborator

@blushi this looks good, I think we should just reword the paragraph above the email (which could be separate task) to: "Input an email address to receive a receipt of your purchase. Note: You will receive an email with instructions to link this email to your account, allowing for easier access going forward, if desired.". Reason being that when I first glanced at the paragraph I read the "this is entirely optional" as pertaining to the field itself being optional.

@blushi
Copy link
Member Author

blushi commented Jan 22, 2025

@blushi this looks good, I think we should just reword the paragraph above the email (which could be separate task) to: "Input an email address to receive a receipt of your purchase. Note: You will receive an email with instructions to link this email to your account, allowing for easier access going forward, if desired.". Reason being that when I first glanced at the paragraph I read the "this is entirely optional" as pertaining to the field itself being optional.

Agreed, I also thought "this is entirely optional" at the end could be confusing.
I can update here.

@blushi blushi force-pushed the fix-APP-406-web3-credit-card branch from 15dab8c to e552a7d Compare January 22, 2025 09:23
@blushi blushi merged commit b31bd3d into dev Jan 22, 2025
14 checks passed
@blushi blushi deleted the fix-APP-406-web3-credit-card branch January 22, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants