Reduce closed-event logging; code clean-up#385
Merged
Conversation
673b0a0 to
89a3568
Compare
89a3568 to
e2a3e73
Compare
Member
|
Solid, @webbnh. Thanks! |
ralphbean
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code produces a message like
on basically every downstream update. This is noisy and confusing (since most updates are not a "closed event").
This PR modifies the code to produce that message only if the issue status actually is "Closed".
And, while we're at it, this PR includes a few other clean-ups:
jira.clientwhich should bejira.client.JIRAdownstreamparameter frommatch_user()_update_on_close(), and enhance the log message there.And, as it happens, this change causes one of the unit tests to fail, so this PR adds a new unit test which correctly represents the original scenario, and this change updates the original test to test the "issue is now closed" scenario. Also, the original test was creating a mock for
_update_assignee()which it wasn't referencing, so I added an assertion for it, as well.