fix: properly handle cyclic nodes with getParentClientNodes

[BlankParticle]

getParentClientNodes recursively goes through and figures out the module graph, but there is no protection against import cycles in the traversal, which leads to max Callstack errors everytime a file within the cycle is changed

import cycles are obvisouly not a good thing, I have tried to figure out the cyclic import but has been unable to find it. I have tried https://github.com/sverweij/dependency-cruiser but it was unable to find anything. so I did some debuging and found that the cycle involves virtual:cloudflare/worker-entry, which makes it way harder to detect as its a virtual module. so I am still unable to figure out the issue.

Which is why I just fixed the function to keep track of seen modules, this also removes the need of extra uniqueModule function which make this slightly better

fixes #14670

[changeset-bot]

🦋 Changeset detected

Latest commit: a7f8e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@react-router/dev	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch
react-router	Patch
react-router-dom	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @BlankParticle,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[BlankParticle]

@brophdawg11 hey It has been a long time since I made this PR, I was wondering if anyone can checkout the PR?

[brophdawg11]

Can you open an issue with a minimal reproduction we could use as an example to evaluate the fix?

[BlankParticle]

took some time to figure out how to best reprod it
made #14670

[markdalgleish]

Thanks for the PR!

[github-actions]

🤖 Hello there,

We just published version 7.12.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 7.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!