Skip to content

Conversation

@alicenstar
Copy link
Member

This comes from a question a vendor posed here: https://github.com/replicated-collab/grammatech-replicated/issues/50#issuecomment-2405787343

I'm open to better ways to present/phrase this. Wasn't sure exactly where to put it.

@alicenstar alicenstar added type::chore type::docs Improvements or additions to documentation labels Oct 10, 2024
@alicenstar alicenstar requested a review from a team as a code owner October 10, 2024 19:23
@netlify
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for replicated-docs ready!

Name Link
🔨 Latest commit 9efa5cb
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs/deploys/67084daa4ca959000833d92b
😎 Deploy Preview https://deploy-preview-2730--replicated-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for replicated-docs-upgrade ready!

Name Link
🔨 Latest commit 9efa5cb
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs-upgrade/deploys/67084daa56cedb0008bb9819
😎 Deploy Preview https://deploy-preview-2730--replicated-docs-upgrade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@paigecalvert paigecalvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicenstar let me know what you think of this edit...I moved it up the Limitations section with a sentence that says the session length is not configurable (which I guess would be real "limitation" here). I was thinking this might make sense since it looked like the vendor was asking about changing the session details. If the feature is ever added, then this limitation would be removed in favor of more detailed docs on how to configure it. WDYT?

@paigecalvert
Copy link
Contributor

@alicenstar going to merge this one. LMK if it shouldn't be and I can revert/edit as needed.

@paigecalvert paigecalvert merged commit 56c5292 into main Oct 16, 2024
5 checks passed
@paigecalvert paigecalvert deleted the alicenstar-patch-1 branch October 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::chore type::docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants