don't relink /nix/store paths #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
approved these changes
Jun 18, 2025
ryantm
left a comment
ryantm
left a comment
There was a problem hiding this comment.
Looks good to me but probably @airportyh should look too!
airportyh
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some programs are broken when there
/nix/store/...../lib/library.solibs are attempted and relinked to other versions of the library. We should always honor nix store library paths.What changed
No longer try to relink libraries set to /nix/store
Test plan
Test on dynamic executables from external sources to confirm that regular functionality is not broken.
Rollout