Update to Rerun 0.23 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
commented
Apr 24, 2025
src/imu_player.cpp
Outdated
|
|
||
| if (false) { | ||
| // TODO: remove, once we figure out why this doesn't generate a warning | ||
| _rec->log(_entity_path + "/magnetometer/z", rerun::Scalar(magTesla[2])); |
There was a problem hiding this comment.
rerun::Scalar is marked as [[deprecated]], so this should generate a warning… but it doesn't.
How can a 40 year old programming language focused on legacy code not have this nailed down already?
There was a problem hiding this comment.
See also rerun-io/rerun#9406
There was a problem hiding this comment.
I commented in slack, but this appears to originate in the way we disable these warnings using RR_DISABLE_DEPRECATION_WARNING. I'm getting additional context on why we're doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.