Skip to content

Update to Rerun 0.23 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Update to Rerun 0.23 #22

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0608f4
Update to Rerun 0.23 RC4
emilk Apr 24, 2025
49e3426
Use 0.23 final
emilk Apr 24, 2025
2615412
Remove call to old Scalar
emilk Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ endif()

# Rerun:
include(FetchContent)
FetchContent_Declare(rerun_sdk URL https://github.com/rerun-io/rerun/releases/download/0.22.0/rerun_cpp_sdk.zip)
FetchContent_Declare(rerun_sdk URL https://build.rerun.io/commit/3bdf696/rerun_cpp_sdk.zip)
FetchContent_MakeAvailable(rerun_sdk)

# VRS:
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ If you choose not to use pixi, you will need to install a few things yourself be
The Rerun C++ SDK works by connecting to an awaiting Rerun Viewer over TCP.

If you need to install the viewer, follow the [installation guide](https://www.rerun.io/docs/getting-started/installing-viewer). Two of the more common ways to install the Rerun Viewer are:
* Via cargo: `cargo install rerun-cli@0.22.0 --locked`
* Via pip: `pip install rerun-sdk==0.22.0`
* Via cargo: `cargo install rerun-cli@0.23.0 --locked`
* Via pip: `pip install rerun-sdk==0.23.0`

After you have installed it, you should be able to type `rerun` in your terminal to start the viewer.

Expand Down
17 changes: 8 additions & 9 deletions src/imu_player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,21 +99,20 @@ namespace rerun_vrs {

void IMUPlayer::log_accelerometer(const std::array<float, 3>& accelMSec2) {
_rec->log(_entity_path + "/accelerometer", rerun::Arrows3D::from_vectors({accelMSec2}));
_rec->log(_entity_path + "/accelerometer/x", rerun::Scalar(accelMSec2[0]));
_rec->log(_entity_path + "/accelerometer/y", rerun::Scalar(accelMSec2[1]));
_rec->log(_entity_path + "/accelerometer/z", rerun::Scalar(accelMSec2[2]));
_rec->log(_entity_path + "/accelerometer", rerun::Scalars(accelMSec2));
}

void IMUPlayer::log_gyroscope(const std::array<float, 3>& gyroRadSec) {
_rec->log(_entity_path + "/gyroscope/x", rerun::Scalar(gyroRadSec[0]));
_rec->log(_entity_path + "/gyroscope/y", rerun::Scalar(gyroRadSec[1]));
_rec->log(_entity_path + "/gyroscope/z", rerun::Scalar(gyroRadSec[2]));
_rec->log(_entity_path + "/gyroscope", rerun::Scalars(gyroRadSec));
}

void IMUPlayer::log_magnetometer(const std::array<float, 3>& magTesla) {
_rec->log(_entity_path + "/magnetometer/x", rerun::Scalar(magTesla[0]));
_rec->log(_entity_path + "/magnetometer/y", rerun::Scalar(magTesla[1]));
_rec->log(_entity_path + "/magnetometer/z", rerun::Scalar(magTesla[2]));
_rec->log(_entity_path + "/magnetometer", rerun::Scalars(magTesla));

if (false) {
// TODO: remove, once we figure out why this doesn't generate a warning
_rec->log(_entity_path + "/magnetometer/z", rerun::Scalar(magTesla[2]));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rerun::Scalar is marked as [[deprecated]], so this should generate a warning… but it doesn't.

How can a 40 year old programming language focused on legacy code not have this nailed down already?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also rerun-io/rerun#9406

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented in slack, but this appears to originate in the way we disable these warnings using RR_DISABLE_DEPRECATION_WARNING. I'm getting additional context on why we're doing this.

}
}

bool might_contain_imu_data(const vrs::StreamId& id) {
Expand Down
Loading