Skip to content

Conversation

lucasmerlin
Copy link
Member

@lucasmerlin lucasmerlin commented Sep 19, 2025

This adds a comment to the web-viewer pr comment action that links to the kitdiff viewer to make it easy to review snapshot changes. Kitdiff needs some more work though.

There also are some changes to theme.ron to have some diff to test with, which should be removed before merging.

@lucasmerlin lucasmerlin added the do-not-merge Do not merge this PR label Sep 19, 2025
Copy link

github-actions bot commented Sep 19, 2025

Web viewer built successfully.

Result Commit Link Manifest
0bf33a0 https://rerun.io/viewer/pr/11282 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.


"panel_bg_color": {
"color": "{Gray.100}"
"color": "{Red.100}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you read the diff before opening this PR?

Copy link
Member Author

@lucasmerlin lucasmerlin Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this was on purpose, I wanted to have a testcase for the kitdiff integration. That's why I added do-not-merge label. Should have been draft of course, I kind of rushed this before the demo.

@lucasmerlin lucasmerlin marked this pull request as draft September 22, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to update kittest images
2 participants