Skip to content

Add kitdiff comment to PRs #11282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add kitdiff comment to PRs #11282

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8090a88
Add kitdiff comment
lucasmerlin Sep 19, 2025
8366d82
Some random color changes for effect
lucasmerlin Sep 19, 2025
46ea483
Fix order
lucasmerlin Sep 19, 2025
0bf33a0
Make invalid wrong color valid wrong color
lucasmerlin Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/reusable_build_web.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ jobs:
| ------ | ------- | ----- | -------- |
| ⏳ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) |

View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}).

<sup>Note: This comment is updated whenever you push a commit.</sup>

- name: Set up Rust
Expand Down Expand Up @@ -125,4 +127,6 @@ jobs:
| ------ | ------- | ----- | -------- |
| ❌ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) |

View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}).

<sup>Note: This comment is updated whenever you push a commit.</sup>
4 changes: 4 additions & 0 deletions .github/workflows/reusable_upload_web.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ jobs:
| ------ | ------- | ---- | -------- |
| ✅ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) |

View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}).

<sup>Note: This comment is updated whenever you push a commit.</sup>

- name: Status comment
Expand All @@ -169,4 +171,6 @@ jobs:
| ------ | ------- | ----- |
| ❌ | ${{ steps.get-sha.outputs.sha }} | https://rerun.io/viewer/pr/${{ github.event.pull_request.number }} | [`+nightly`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) [`+main`](https://rerun.io/viewer/pr/${{ github.event.pull_request.number }}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) |

View image diff on [kitdiff](https://rerun-io.github.io/kitdiff/?url=${{github.event.pull_request.html_url}}).

<sup>Note: This comment is updated whenever you push a commit.</sup>
6 changes: 3 additions & 3 deletions crates/viewer/re_ui/data/dark_theme.ron
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
},

"panel_bg_color": {
"color": "{Gray.100}"
"color": "{Red.100}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you read the diff before opening this PR?

Copy link
Member Author

@lucasmerlin lucasmerlin Sep 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this was on purpose, I wanted to have a testcase for the kitdiff integration. That's why I added do-not-merge label. Should have been draft of course, I kind of rushed this before the demo.

},
"text_edit_bg_color": {
"color": "{Gray.200}"
Expand Down Expand Up @@ -203,10 +203,10 @@
"color": "{Gray.550}"
},
"text_default": {
"color": "{Gray.775}"
"color": "{Gray.355}"
},
"text_strong": {
"color": "{Gray.1000}"
"color": "{Green.1000}"
},
"error_fg_color": {
"color": "#AB0116"
Expand Down
Loading