Skip to content

Conversation

lucasmerlin
Copy link
Member

@lucasmerlin lucasmerlin commented Sep 19, 2025

This adds a comment to the web-viewer pr comment action that links to the kitdiff viewer to make it easy to review snapshot changes. Kitdiff needs some more work though.

There also are some changes to theme.ron to have some diff to test with, which should be removed before merging.

@lucasmerlin lucasmerlin added the do-not-merge Do not merge this PR label Sep 19, 2025
Copy link

github-actions bot commented Sep 19, 2025

Web viewer built successfully.

Result Commit Link Manifest
0bf33a0 https://rerun.io/viewer/pr/11282 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@lucasmerlin lucasmerlin marked this pull request as draft September 22, 2025 11:13
@lucasmerlin lucasmerlin added 🚢 CI and removed do-not-merge Do not merge this PR labels Oct 15, 2025
@lucasmerlin lucasmerlin marked this pull request as ready for review October 15, 2025 10:43
@lucasmerlin lucasmerlin added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Oct 15, 2025
@lucasmerlin lucasmerlin merged commit 70a9596 into main Oct 15, 2025
36 of 37 checks passed
@lucasmerlin lucasmerlin deleted the lucas/kitdiff-comment branch October 15, 2025 12:53
grtlr pushed a commit that referenced this pull request Oct 16, 2025
This adds a comment to the web-viewer pr comment action that links to
the kitdiff viewer to make it easy to review snapshot changes. Kitdiff
needs some more work though.

There also are some changes to theme.ron to have some diff to test with,
which should be removed before merging.

- closes #10991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it easier to update kittest images

2 participants