Skip to content

Conversation

oxkitsune
Copy link
Member

Related

What

This changes our ros2_reflection parser to put the entire message behind a single component to make it easier to extract it from lenses.

@oxkitsune oxkitsune added include in changelog 🧢 MCAP Everything related to the MCAP support labels Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

Web viewer built successfully.

Result Commit Link Manifest
55adc97 https://rerun.io/viewer/pr/11480 +nightly +main

Note: This comment is updated whenever you push a commit.

@oxkitsune oxkitsune changed the title Reflection-based ros2 parser now only returns single component Reflection-based ROS2 parser now only returns single component Oct 9, 2025
@grtlr grtlr requested a review from Copilot October 10, 2025 08:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the ROS2 reflection-based parser to consolidate all message fields under a single component named "message" instead of creating separate components for each field, making it easier to extract complete messages from lenses.

  • Replaced individual field components with a single "message" component containing a struct
  • Removed the empty message handling logic and associated helper function
  • Updated the parser to use a single FixedSizeListBuilder with MessageStructBuilder

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/utils/re_mcap/src/layers/ros2_reflection.rs Core parser logic updated to use single component structure
tests/assets/rrd/snippets/howto/load_mcap.rrd Test asset updated with new binary hash/size
crates/store/re_data_loader/tests/snapshots/test_mcap_loader__tests__ros2.snap Snapshot updated with new binary hash/size

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great to have this in line with protobuf parsing!

@grtlr grtlr merged commit bede6ca into main Oct 10, 2025
69 of 70 checks passed
@grtlr grtlr deleted the gijs/ros2-reflection-single-component branch October 10, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog 🧢 MCAP Everything related to the MCAP support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants