Skip to content

Conversation

@IsseW
Copy link
Member

@IsseW IsseW commented Dec 2, 2025

Related

What

Implements size bytes for the transform cache so its memory usage shows up in the memory panel.

image

@IsseW IsseW added 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 2, 2025
@IsseW IsseW requested a review from Copilot December 2, 2025 08:54
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Web viewer built successfully.

Result Commit Link Manifest
acd5497 https://rerun.io/viewer/pr/12038 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements memory size tracking for the transform cache by adding SizeBytes trait implementations to various transform-related types, enabling their memory usage to appear in the memory panel.

Key Changes:

  • Added SizeBytes implementations for transform cache structures
  • Added glam::DAffine3 to the list of primitive types with size tracking
  • Connected transform cache memory reporting to use the new size tracking

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/viewer/re_view_spatial/src/caches/transform_database_store.rs Implements SizeBytes for TransformDatabaseStoreCache and updates memory_report to use the new size tracking
crates/utils/re_byte_size/src/primitive_sizes.rs Adds SizeBytes implementation for glam::DAffine3 type
crates/utils/re_byte_size/Cargo.toml Adds glam workspace dependency
crates/store/re_tf/src/transform_resolution_cache.rs Implements SizeBytes for multiple transform-related types including TransformResolutionCache, ParentFromChildTransform, CachedTransformsForTimeline, CachedTransformValue, TransformsForChildFrameEvents, TransformsForChildFrame, and ResolvedPinholeProjection
crates/store/re_tf/src/frame_id_registry.rs Implements SizeBytes for FrameIdRegistry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Wumpf Wumpf self-requested a review December 2, 2025 09:18
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz do struct deconstruction, see comment
thx!

@IsseW IsseW requested a review from Wumpf December 2, 2025 10:44
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants