Skip to content

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Nov 17, 2025

React Email already does the same. We can still build supporting Node 20, but development now requires Node 22 onwards.


Summary by cubic

Require Node 22+ for development to align with React Email; builds remain compatible with Node 20.

Written for commit cc4185d. Summary will update automatically on new commits.

@gabrielmfern gabrielmfern self-assigned this Nov 17, 2025
@gabrielmfern gabrielmfern requested a review from a team as a code owner November 17, 2025 13:44
@gabrielmfern gabrielmfern mentioned this pull request Nov 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="package.json">

<violation number="1" location="package.json:12">
Updating the package engines to require Node &gt;=22 advertises that the library only runs on Node 22+, but the build still targets es2017 and the PR description states runtime support remains on earlier LTS versions. This will stop Node 18/20 users from installing the package even though it continues to work there. Please keep the runtime requirement at the actual supported version and enforce Node 22 only for local tooling.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@gabrielmfern gabrielmfern merged commit 655f1ed into canary Nov 17, 2025
10 of 11 checks passed
@gabrielmfern gabrielmfern deleted the chore/require-node-20 branch November 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants