Use forked jemalloc pprof and disable parca-debuginfo stripping#4328
Merged
jackkleeman merged 1 commit intomainfrom Feb 6, 2026
Merged
Use forked jemalloc pprof and disable parca-debuginfo stripping#4328jackkleeman merged 1 commit intomainfrom
jackkleeman merged 1 commit intomainfrom
Conversation
1998eb0 to
2ab2ce9
Compare
2ab2ce9 to
d4f34e5
Compare
AhmedSoliman
approved these changes
Feb 6, 2026
Contributor
AhmedSoliman
left a comment
There was a problem hiding this comment.
Amazing investigative work as usual @jackkleeman. Thanks so much for going the extra mile and fixing it.
| tracing = { workspace = true } | ||
|
|
||
| [target.'cfg(not(target_env = "msvc"))'.dependencies] | ||
| jemalloc_pprof = { version = "0.8.1", default-features = false, features = ["symbolize"] } |
Contributor
There was a problem hiding this comment.
If we can leave a comment with the PR we are waiting to be released upstream, just to make it easier to remember why are we using a fork.
d4f34e5 to
f740c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pprof ./restate-server.debug heap.pb.gzand it does not work when they are found in a directoryPPROF_BINARY_PATH=. pprof ./heap.pb.gz. With this change, either works.