[PartitionStore] Allow table key prefix builders to use references#4561
Open
AhmedSoliman wants to merge 6 commits intomainfrom
Open
[PartitionStore] Allow table key prefix builders to use references#4561AhmedSoliman wants to merge 6 commits intomainfrom
AhmedSoliman wants to merge 6 commits intomainfrom
Conversation
Introduces InternedReString, a wrapper around ReString that deduplicates long strings via a per-thread HashSet. Strings longer than size_of::<String>() are stored as Arc<str> and looked up on construction and during deserialization (serde and bilrost), so repeated values share a single heap allocation. Short strings are stored inline and bypass the interner entirely. The bilrost decode path is optimized with a fast path for contiguous buffers: when chunk() covers the full string, we read directly as &str and query the interner without allocating a temporary buffer.
A macro utility for efficiently formatting a restring which may optimize out the heap allocation if the string can be inlined (<= 24 bytes)
This was referenced Apr 3, 2026
Test Results 7 files - 1 7 suites - 1 2m 36s ⏱️ - 1m 7s Results for commit b33c373. ± Comparison against base commit 6725361. This pull request removes 6 tests.♻️ This comment has been updated with latest results. |
AhmedSoliman
changed the title
ServiceName uses the new `InternedReString` for thread-local checked interning when it makes sense. LockName will be used for representing the new service locking mechanism for vqueues that will be introduced in the next commit(s).
- Allows key prefixes and (get) operations no partition store to be encoded without the extra clone into the builder (via the new builder_ref() type). - Allows table key designers to use Option<T> by implementing their own KeyEncode trait with their own semantic of what "None" means.
This was referenced Apr 5, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.