fix(hooks): resolve infinite loop in useFormChangeDetection#1345
Open
thisisharsh7 wants to merge 1 commit intorhesis-ai:mainfrom
Open
fix(hooks): resolve infinite loop in useFormChangeDetection#1345thisisharsh7 wants to merge 1 commit intorhesis-ai:mainfrom
thisisharsh7 wants to merge 1 commit intorhesis-ai:mainfrom
Conversation
![peqy[bot]](https://avatars.githubusercontent.com/in/1930020?s=60&v=4){kind=small}
| useEffect(() => { | ||
| setTrackedInitialData(initialData); | ||
| }, [initialDataString, initialData]); | ||
| }, [initialDataString]); |
There was a problem hiding this comment.
Improvement: Consider adding a short comment (or an exhaustive-deps disable w/ explanation, if that rule is enabled) explaining why initialData is intentionally omitted from the deps here.
Fix: e.g.
// Depend on serialized value to avoid reruns when initialData is recreated by reference (regression #1235)
Contributor
|
@thisisharsh7, thanks for the fix; this behavior was also flagged during development of another feature. We fixed it in another branch. Thank you for checking, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix infinite re-renders in useFormChangeDetection
This PR fixes a regression introduced in #1235.
The useEffect inside useFormChangeDetection had redundant dependencies (initialData and initialDataString), causing unnecessary executions and in some cases infinite re-renders when initialData was recreated by reference.