Skip to content

fix(hooks): resolve infinite loop in useFormChangeDetection #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisisharsh7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(hooks): resolve infinite loop in useFormChangeDetection #1345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/frontend/src/hooks/useFormChangeDetection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function useFormChangeDetection<

useEffect(() => {
setTrackedInitialData(initialData);
}, [initialDataString, initialData]);
}, [initialDataString]);
Copy link

@peqy peqy bot Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement: Consider adding a short comment (or an exhaustive-deps disable w/ explanation, if that rule is enabled) explaining why initialData is intentionally omitted from the deps here.

Fix: e.g. // Depend on serialized value to avoid reruns when initialData is recreated by reference (regression #1235)


const hasChanges = compareFormData(currentData, trackedInitialData);

Expand Down