Skip to content

Refactoring & cleanup in routes & route groups + bug fixes #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasherceg merged 6 commits into from
Apr 26, 2025

Fixed nitpick comment

bc705e7
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Refactoring & cleanup in routes & route groups + bug fixes #1881

Fixed nitpick comment
bc705e7
Select commit
Loading
Failed to load commit list.
GitHub Actions / chrome-tests-Linux-Production-Default completed Apr 26, 2025 in 0s

UI Test Results from chrome on Linux

This run completed at 04/26/2025 11:25:17

Details

Test Results - UI Test Results from chrome on Linux

Expand the following summaries for more details:

Duration: 763.1001901 seconds
Times
Started: 2025-04-26T11:12:24.8651011+00:00
Creation: 2025-04-26T11:12:29.3447383+00:00
Queuing: 2025-04-26T11:12:29.3447383+00:00
Finished: 2025-04-26T11:25:07.9652912+00:00
Duration: 763.1001901 seconds
Outcome: Failed | Total Tests: 550 | Passed: 546 | Failed: 1
Counters
Total: 550
Executed: 547
Passed: 546
Failed: 1
Error: 0
Timeout: 0
Aborted: 0
Inconclusive: 0
PassedButRunAborted: 0
NotRunnable: 0
NotExecuted: 0
Disconnected: 0
Warning: 0
Completed: 0
InProgress: 0
Pending: 0

Tests:

🔘 DotVVM.Samples.Tests.Feature.PostbackConcurrencyTests.Feature_PostbackConcurrency_RedirectPostbackQueue
Name: DotVVM.Samples.Tests.Feature.PostbackConcurrencyTests.Feature_PostbackConcurrency_RedirectPostbackQueue
Class Name: DotVVM.Samples.Tests.Feature.PostbackConcurrencyTests
Outcome: NotExecuted 🔘
Duration: 00:00:00.0010000
🔘 DotVVM.Samples.Tests.Feature.PostbackSpaNavigationTests.PostbackSpaNavigationTest_SuccessfulNavigation_SurvivingStaticCommand
Name: DotVVM.Samples.Tests.Feature.PostbackSpaNavigationTests.PostbackSpaNavigationTest_SuccessfulNavigation_SurvivingStaticCommand
Class Name: DotVVM.Samples.Tests.Feature.PostbackSpaNavigationTests
Outcome: NotExecuted 🔘
Duration: 00:00:00.0010000
🔘 DotVVM.Samples.Tests.Control.CheckBoxTests.Control_CheckBox_CheckedItemsEmpty
Name: DotVVM.Samples.Tests.Control.CheckBoxTests.Control_CheckBox_CheckedItemsEmpty
Class Name: DotVVM.Samples.Tests.Control.CheckBoxTests
Outcome: NotExecuted 🔘
Duration: 00:00:00.0010000
❌ DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts
Name: DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts
Class Name: DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests
Outcome: Failed ❌
Duration: 00:00:01.6058762

Error Message

Riganti.Selenium.Core.Abstractions.Exceptions.SeleniumTestFailedException : 

-----------  Aggregated Inner Exceptions  -----------

// Exception #1: 
OpenQA.Selenium.StaleElementReferenceException: stale element reference: stale element not found in the current frame
  (Session info: chrome=135.0.7049.95); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.InternalExecute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Execute(String commandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.GetAttribute(String attributeName)
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_7(IElementWrapper s) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at System.Linq.Enumerable.SelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.ToArray()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.ToList()
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c__DisplayClass1_0.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__3() in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at Riganti.Selenium.Core.WaitForExecutor.WaitFor(Action condition, Int32 timeout, String failureMessage, Int32 checkInterval, Boolean throwOriginal) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\WaitForExecutor.cs:line 22
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_0(IBrowserWrapper browser) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 52
   at Riganti.Selenium.Core.TestInstance.RunTest(IWebBrowser browser) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 122
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 47
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 57
   at Riganti.Selenium.Core.TestInstance.RetryAsync(Func`1 action, Int32 testAttemptsCount) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 147


// Exception #2: 
OpenQA.Selenium.StaleElementReferenceException: stale element reference: stale element not found in the current frame
  (Session info: chrome=135.0.7049.95); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.InternalExecute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Execute(String commandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.GetAttribute(String attributeName)
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_7(IElementWrapper s) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at System.Linq.Enumerable.SelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.ToArray()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.ToList()
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c__DisplayClass1_0.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__3() in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at Riganti.Selenium.Core.WaitForExecutor.WaitFor(Action condition, Int32 timeout, String failureMessage, Int32 checkInterval, Boolean throwOriginal) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\WaitForExecutor.cs:line 22
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_0(IBrowserWrapper browser) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 52
   at Riganti.Selenium.Core.TestInstance.RunTest(IWebBrowser browser) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 122
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 47
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 57
   at Riganti.Selenium.Core.TestInstance.RetryAsync(Func`1 action, Int32 testAttemptsCount) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 147

---- OpenQA.Selenium.StaleElementReferenceException : stale element reference: stale element not found in the current frame
  (Session info: chrome=135.0.7049.95); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
---- OpenQA.Selenium.StaleElementReferenceException : stale element reference: stale element not found in the current frame
  (Session info: chrome=135.0.7049.95); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception

Error Stack Trace:

   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.InternalExecute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Execute(String commandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.GetAttribute(String attributeName)
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_7(IElementWrapper s) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at System.Linq.Enumerable.SelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.ToArray()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.ToList()
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c__DisplayClass1_0.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__3() in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at Riganti.Selenium.Core.WaitForExecutor.WaitFor(Action condition, Int32 timeout, String failureMessage, Int32 checkInterval, Boolean throwOriginal) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\WaitForExecutor.cs:line 22
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_0(IBrowserWrapper browser) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 52
   at Riganti.Selenium.Core.TestInstance.RunTest(IWebBrowser browser) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 122
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 47
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 57
   at Riganti.Selenium.Core.TestInstance.RetryAsync(Func`1 action, Int32 testAttemptsCount) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 147
----- Inner Stack Trace #1 (OpenQA.Selenium.StaleElementReferenceException) -----
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.InternalExecute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Execute(String commandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.GetAttribute(String attributeName)
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_7(IElementWrapper s) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at System.Linq.Enumerable.SelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.ToArray()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.ToList()
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c__DisplayClass1_0.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__3() in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at Riganti.Selenium.Core.WaitForExecutor.WaitFor(Action condition, Int32 timeout, String failureMessage, Int32 checkInterval, Boolean throwOriginal) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\WaitForExecutor.cs:line 22
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_0(IBrowserWrapper browser) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 52
   at Riganti.Selenium.Core.TestInstance.RunTest(IWebBrowser browser) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 122
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 47
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 57
   at Riganti.Selenium.Core.TestInstance.RetryAsync(Func`1 action, Int32 testAttemptsCount) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 147
----- Inner Stack Trace #2 (OpenQA.Selenium.StaleElementReferenceException) -----
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.InternalExecute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Execute(String commandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.GetAttribute(String attributeName)
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_7(IElementWrapper s) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at System.Linq.Enumerable.SelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.WhereEnumerableIterator`1.ToArray()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.ToList()
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<>c__DisplayClass1_0.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__3() in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 55
   at Riganti.Selenium.Core.WaitForExecutor.WaitFor(Action condition, Int32 timeout, String failureMessage, Int32 checkInterval, Boolean throwOriginal) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\WaitForExecutor.cs:line 22
   at DotVVM.Samples.Tests.Feature.JsComponentIntegrationTests.<Feature_JsComponentIntegrationTests_ReactComponentIntegration_Recharts>b__1_0(IBrowserWrapper browser) in /_/src/Samples/Tests/Tests/Feature/JsComponentIntegrationTests.cs:line 52
   at Riganti.Selenium.Core.TestInstance.RunTest(IWebBrowser browser) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 122
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 47
   at Riganti.Selenium.Core.TestInstance.RunAsyncCore() in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 57
   at Riganti.Selenium.Core.TestInstance.RetryAsync(Func`1 action, Int32 testAttemptsCount) in D:\ba\_work\129\s\src\Core\Riganti.Selenium.Core\TestInstance.cs:line 147
View more details on GitHub Actions