target/riscv: Regenerate debug_defines.{c,h} from current riscv-debug…#1253
Open
berolinux wants to merge 1 commit intoriscv-collab:riscvfrom
Open
target/riscv: Regenerate debug_defines.{c,h} from current riscv-debug…#1253berolinux wants to merge 1 commit intoriscv-collab:riscvfrom
berolinux wants to merge 1 commit intoriscv-collab:riscvfrom
Conversation
…-spec This pulls in some improvements from the riscv-debug-spec repo, and cleans up the licensing (riscv-debug-spec changed the license to dual CC-BY-4.0 and BSD-2-Clause specifically to make sure the generated debug_defines files don't conflict with OpenOCD licensing) Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
en-sc
suggested changes
May 7, 2025
| * This file is auto-generated by running 'make debug_defines' in | ||
| * https://github.com/riscv/riscv-debug-spec/ (40b9a05) | ||
| */ | ||
| /* SPDX-License-Identifier: BSD-2-Clause OR CC-BY-4.0 */ |
Collaborator
There was a problem hiding this comment.
Please, fix the SPDX identifier:
Suggested change
| /* SPDX-License-Identifier: BSD-2-Clause OR CC-BY-4.0 */ | |
| // SPDX-License-Identifier: BSD-2-Clause OR CC-BY-4.0 |
| /* | ||
| * When any trap into M-mode is taken, \FcsrTcontrolMte is set to 0. When {\tt | ||
| * mret} is executed, \FcsrTcontrolMte is set to the value of \FcsrTcontrolMpte. | ||
| * When any trap into M-mode is taken, {tcontrol-mte} is set to 0. When `mret` is executed, {tcontrol-mte} is set to the value of {tcontrol-mpte}. |
Collaborator
There was a problem hiding this comment.
Please, add Checkpatch-ignore: LONG_LINE_COMMENT to the commit footer.
See 26f2df8 for an example.
Collaborator
JanMatCodasip
left a comment
JanMatCodasip
left a comment
There was a problem hiding this comment.
I checked this PR visually and it looks OK to me. I do not have any more comments than what @en-sc already pointed out.
Collaborator
|
FYI: It appears that the upstream sync patch is based on this unmerged PR: https://review.openocd.org/c/openocd/+/8893 It would be useful to merge and rebase it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
target/riscv: Regenerate debug_defines.{c,h} from current riscv-debug-spec
This pulls in some improvements from the riscv-debug-spec repo, and cleans up the licensing (riscv-debug-spec changed the license to dual CC-BY-4.0 and BSD-2-Clause specifically to make sure the generated debug_defines files don't conflict with OpenOCD licensing)