fix error detection during trigger removal#1296
Open
aap-sc wants to merge 1 commit intoriscv-collab:riscvfrom
Open
fix error detection during trigger removal#1296aap-sc wants to merge 1 commit intoriscv-collab:riscvfrom
aap-sc wants to merge 1 commit intoriscv-collab:riscvfrom
Conversation
aap-sc
added a commit
to syntacore/openocd
that referenced
this pull request
Oct 7, 2025
The error manifests on designs that allow CSR reads when hart is not halted. This results in `rwp` command to erroneously report "success" See: riscv-collab/riscv-openocd#1296 Signed-off-by: Parshintsev Anatoly <anatoly.parshintsev@syntacore.com>
The error manifests on designs that allow CSR reads when hart is not halted. This results in `rwp` command to erroneously report "success" Signed-off-by: Parshintsev Anatoly <anatoly.parshintsev@syntacore.com>
aap-sc
force-pushed
the
aap-sc/rwp_fixup
branch
from
785bda1 to
60585af
Compare
aap-sc
added a commit
to syntacore/openocd
that referenced
this pull request
Oct 7, 2025
The error manifests on designs that allow CSR reads when hart is not halted. This results in `rwp` command to erroneously report "success" See: riscv-collab/riscv-openocd#1296 Signed-off-by: Parshintsev Anatoly <anatoly.parshintsev@syntacore.com>
en-sc
approved these changes
Oct 7, 2025
Collaborator
en-sc
left a comment
en-sc
left a comment
There was a problem hiding this comment.
LGTM (reviewed internally).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error manifests on designs that allow CSR reads when hart is not halted. This results in
rwpcommand to erroneously report "success"