Fix: Memory leak in riscv_openocd_step_impl() #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional debug logs to verify correct retrieval and printing of progbufsize in various code paths within riscv-013.c. This helps in debugging hardware configurations that expose custom program buffer sizes. Signed-off-by: Biancaa Ramesh <[email protected]>
…d-write Added a check for have_progbuf_size before attempting to execute. This prevents program buffer access on targets that do not support it, improving robustness and avoiding potential execution failures when the program buffer is not available or too small. Signed-off-by: Biancaa Ramesh <[email protected]>
Fixes a memory leak caused by wps_to_enable being allocated with calloc() and never freed. The pointer is now properly freed at the end of the function and on early error returns. This leak was originally introduced in commit 5a8697b (trigger management refactor). Signed-off-by: Biancaa Ramesh [email protected]
Signed-off-by: Biancaa Ramesh <[email protected]>
|
@Biancaa-R, thank you for the patch. Unfortunately, there is already a patch with a fix. I should have mentioned it in the issue, sorry. |
Are you referring to introducing test runs under Valgrind to the CI? |
Yes I am ,to ensure it is caught . |
Oh no worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleared wps_to_enable in _exit after there is no further reference to it .
The memory allocated at :
Fixes the issue: #1284