[Zilsd] Clarify Symbol Pseudos for Zilsd #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing documentation didn't mention that `ld` and `sd` symbol pseudos aren't available on RV32. This change clarifies that these are available, but denote pair load/stores using the Zilsd instructions.
Contributor
Author
|
These have been proposed for: |
MaskRay
reviewed
Apr 9, 2025
src/asm-manual.adoc
Outdated
| 1c: R_RISCV_PCREL_LO12_S .L0 | ||
| ---- | ||
|
|
||
| On RV32, `ld <rd>, <symbol>` and `sd <rd>, <symbol>, <rt>` can be used to |
There was a problem hiding this comment.
Is <symbol>+<offset> allowed?
(Allowed in gas and llvm but the llvm AsmParser is a bit of a hack.)
Contributor
Author
There was a problem hiding this comment.
LLVM looks like it is passing the offset through to the relocation correctly, so I'm happy to allow this. I can clarify the wording to ensure it is, because there are other places that allow <symbol>{+<offset>} when they only say <symbol> right now.
Contributor
Author
There was a problem hiding this comment.
I updated this to be <symbol expression> which can be symbol, offset, or symbol with offset.
MaskRay
approved these changes
Apr 26, 2025
cmuellner
approved these changes
May 8, 2025
Collaborator
cmuellner
left a comment
cmuellner
left a comment
There was a problem hiding this comment.
We discussed this briefly in today's SIG Toolchain meeting and agreed there to land this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing documentation didn't mention that
ldandsdsymbol pseudos aren't available on RV32. This change clarifies that these are available, but denote pair load/stores using the Zilsd instructions.