Skip to content

[Zilsd] Clarify Symbol Pseudos for Zilsd #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

[Zilsd] Clarify Symbol Pseudos for Zilsd #128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfe41d7
[Zilsd] Clarify Symbol Pseudos for Zilsd
lenary Apr 9, 2025
cae00e5
Clarify that Symbol Pseudos accept Symbol Expressions
lenary Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/asm-manual.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,10 @@ as seen by `objdump`:
1c: R_RISCV_PCREL_LO12_S .L0
----

On RV32, `ld <rd>, <symbol>` and `sd <rd>, <symbol>, <rt>` can be used to
Copy link

@MaskRay MaskRay Apr 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is <symbol>+<offset> allowed?

(Allowed in gas and llvm but the llvm AsmParser is a bit of a hack.)

Copy link
Contributor Author

@lenary lenary Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM looks like it is passing the offset through to the relocation correctly, so I'm happy to allow this. I can clarify the wording to ensure it is, because there are other places that allow <symbol>{+<offset>} when they only say <symbol> right now.

Copy link
Contributor Author

@lenary lenary Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this to be <symbol expression> which can be symbol, offset, or symbol with offset.

generate a sequence including the `ld` and `sd` instructions in Zilsd -- in
these cases, `<rd>` denotes the even GPR in an even-odd GPR pair.

== Constants

The following example shows loading a constant using the `%hi` and
Expand Down
Loading