Fix // masked functions in C.7.7 and C.7.8
#407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfusik
commented
Jul 10, 2025
| "vcreate", "vlm_v" | ||
| ] | ||
| if any(i in name for i in unsupported_op): | ||
| if any(i in name for i in unsupported_op) or name == "id": |
Author
There was a problem hiding this comment.
Cannot match "id" substring because of "slide".
Comment on lines
+439
to
+440
| self.do_not_have_overloaded_variant = not self.has_tail_policy and not any( | ||
| Generator.is_support_overloaded(op) for op in op_list) |
Author
There was a problem hiding this comment.
This enabled viota/vid with tail policy for wrong reasons: they weren't matched by unsupported_op.
Now that they are matched, we need to skip this match in the D appendix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.