Skip to content

Fix // masked functions in C.7.7 and C.7.8 #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix // masked functions in C.7.7 and C.7.8 #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions auto-generated/overloaded_intrinsic_funcs.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38828,19 +38828,11 @@ vbool64_t __riscv_vmsof(vbool64_t vm, vbool64_t vs2, size_t vl);

[[overloaded-vector-iota]]
==== Vector Iota Intrinsics

[,c]
----
// masked functions
----
Intrinsics here don't have an overloaded variant.

[[overloaded-vector-element-index]]
==== Vector Element Index Intrinsics

[,c]
----
// masked functions
----
Intrinsics here don't have an overloaded variant.

=== Vector Permutation Intrinsics

Expand Down
12 changes: 2 additions & 10 deletions auto-generated/overloaded_intrinsic_funcs/06_vector_mask_intrinsics.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,8 @@ vbool64_t __riscv_vmsof(vbool64_t vm, vbool64_t vs2, size_t vl);

[[overloaded-vector-iota]]
==== Vector Iota Intrinsics

[,c]
----
// masked functions
----
Intrinsics here don't have an overloaded variant.

[[overloaded-vector-element-index]]
==== Vector Element Index Intrinsics

[,c]
----
// masked functions
----
Intrinsics here don't have an overloaded variant.
12 changes: 5 additions & 7 deletions rvv-intrinsic-generator/rvv_intrinsic_gen/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ def is_support_overloaded(name, **kwargs):
if re.match(p, name) and name[-2:] != "_m":
return False
unsupported_op = [
"setvl", "vundefined", "viota", "vmclr", "vmset", "vid", "vmv_v_x",
"vfmv_v_f", "vcreate", "vlm_v"
"setvl", "vundefined", "iota", "vmclr", "vmset", "vmv_v_x", "vfmv_v_f",
"vcreate", "vlm_v"
]
if any(i in name for i in unsupported_op):
if any(i in name for i in unsupported_op) or name == "id":
Copy link
Author

@pfusik pfusik Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot match "id" substring because of "slide".

return False

if name.startswith("sf_vc"):
Expand Down Expand Up @@ -436,10 +436,8 @@ def function_group(self,
lmul_list,
decorator_list,
description=None):
self.do_not_have_overloaded_variant = True
for op in op_list:
if Generator.is_support_overloaded(op):
self.do_not_have_overloaded_variant = False
self.do_not_have_overloaded_variant = not self.has_tail_policy and not any(
Generator.is_support_overloaded(op) for op in op_list)
Comment on lines +439 to +440
Copy link
Author

@pfusik pfusik Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enabled viota/vid with tail policy for wrong reasons: they weren't matched by unsupported_op.
Now that they are matched, we need to skip this match in the D appendix.

super().function_group(
template,
title,
Expand Down