Skip to content

Fix dtc_output read when interrupted by EINTR #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dtc_output read when interrupted by EINTR #1801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions riscv/dts.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,11 @@ static std::string dtc_compile(const std::string& dtc_input, bool compile)

int got;
char buf[4096];
while ((got = read(dtc_output_pipe[0], buf, sizeof(buf))) > 0) {
dtc_output.write(buf, got);
}
do {
while ((got = read(dtc_output_pipe[0], buf, sizeof(buf))) > 0) {
dtc_output.write(buf, got);
}
} while (got == -1 && errno == EINTR); // Retry the read() if it was interrupted by a signal
if (got == -1) {
std::cerr << "Failed to read dtc_output: " << strerror(errno) << std::endl;
exit(1);
Expand Down