Created common base class called "Portfolio" that both Profiles and CRDs use. #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks ready to merge into main if you approve. |
Collaborator
Author
|
I made the 3 commits for this PR and then did 2 more commits (in a new branch off main #238) and then did a PR for it (#242). Since the first PR (#241) wasn't merged into main when I created branch #238, I had to merge the commits from #241 into #238 (so it has 5 commits). BTW, I wanted to ask you how to best handle this situation. What I did for my current branch is to base it off the branch #238 and that was nice because all 5 commits we already present in my workspace. |
Collaborator
Author
|
Can you merge this? |
dhower-qc
approved these changes
Nov 7, 2024
james-ball-qualcomm
deleted the
58-reduce-duplicate-code-between-profiles-and-crds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #58