Fix issues in adoc to HTML formatting found by Copilot review#145
Fix issues in adoc to HTML formatting found by Copilot review#145james-ball-qualcomm merged 7 commits intomainfrom
Conversation
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix AsciiDoc to HTML formatting issues and add support for nested formatting (e.g., *_bold italics_*). The changes refactor the formatting functions to use a recursive parameter and introduce a new convert_nested function to handle nested formatting markers.
Key Changes
- Refactored
constrained_format_patternandunconstrained_format_patternto accept arecursiveparameter for nested formatting support - Introduced
convert_nestedfunction to recursively process formatting within already-captured content - Renamed and consolidated formatting functions (
convert_bold,convert_italics,convert_monospace→convert_unconstrainedandconvert_constrained) - Updated documentation to reflect the new functionality and remove obsolete examples
- Added test cases for nested formatting in
tests/norm-rule/test.yaml
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/create_normative_rules.rb | Core implementation of nested formatting support, refactoring of formatting functions, and updated documentation |
| tests/norm-rule/test.yaml | Added test cases for nested formatting (nested bold, bold+italics, bold+italics+monospace) |
| tests/norm-rule/expected/test-norm-rules.html | Expected HTML output showing nested formatting conversions (contains bugs - nested formatters not converted) |
| tests/norm-rule/expected/test-norm-rules.json | Expected JSON output with updated test case data |
| tests/norm-rule/expected/test-norm-rules.adoc | Expected AsciiDoc output with updated test case formatting |
| tests/norm-rule/expected/test-norm-rules.xlsx | Binary Excel file with updated test case data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: james-ball-qualcomm <quic_jameball@quicinc.com>
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
…d-by-copilot' into 144-fix-issues-found-by-copilot
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
No description provided.