fix: '<slt:ignore>' false negative in default validator#278
Open
2010YOUY01 wants to merge 1 commit intorisinglightdb:mainfrom
Open
fix: '<slt:ignore>' false negative in default validator#2782010YOUY01 wants to merge 1 commit intorisinglightdb:mainfrom
2010YOUY01 wants to merge 1 commit intorisinglightdb:mainfrom
Conversation
Signed-off-by: Yongting You <2010youy01@gmail.com>
2010YOUY01
force-pushed
the
slt-ignore
branch
from
f323b53 to
87d84c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we add the test case to
basic.sltIt passes.
This PR fixes the above case.