Skip to content

fix: '<slt:ignore>' false negative in default validator #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2010YOUY01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: '<slt:ignore>' false negative in default validator #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions sqllogictest/src/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,11 +506,18 @@ pub fn default_validator(
let actual_snapshot = actual_rows.join("\n");
let fragments: Vec<&str> = expected_snapshot.split(IGNORE_MARKER).collect();
let mut pos = 0;
for frag in fragments {
for (i, frag) in fragments.iter().enumerate() {
if frag.is_empty() {
continue;
}
if let Some(idx) = actual_snapshot[pos..].find(frag) {
// Edge case: The following example is expected to fail
// Actual - 'foo bar baz'
// Expected - 'bar <slt:ignore>'
if (i == 0) && (idx != 0) {
return false;
}

pos += idx + frag.len();
} else {
tracing::error!(
Expand Down Expand Up @@ -2361,7 +2368,10 @@ Caused by:
"beta".to_string(),
"gamma".to_string(),
]];
let expected = vec!["alpha<slt:ignore>delta".to_string()];
assert!(!default_validator(normalizer, &actual, &expected));
let expected1 = vec!["alpha<slt:ignore>delta".to_string()];
assert!(!default_validator(normalizer, &actual, &expected1));

let expected2 = vec!["pha<slt:ignore>gamma".to_string()];
assert!(!default_validator(normalizer, &actual, &expected2));
}
}
Loading