Conversation
c981692 to
d888d84
Compare
d07d887 to
0358e2a
Compare
- Remove needsReload trigger from dataBind property changes - Add in-place binding update methods for both platforms - Fix flicker when switching between binding modes iOS Changes: - Add applyDataBinding() method on RiveReactNativeView - Call applyDataBinding() in didSet instead of needsReload - Directly call bind/enableAutoBind/disableAutoBind on existing view Android Changes: - Add custom setter for dataBind property - Add configureDataBinding() method - Directly update viewModelInstance on existing state machine - Make riveAnimationView internal for access from HybridRiveView Result: - Smooth transitions between red/green/blue/none/auto modes - No visual flicker or reload when switching binding modes - Better performance (no view recreation) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add artboard.bind(viewModelInstance:) in addition to stateMachine binding - Required for visual changes to take effect when switching binding modes - Matches old rive-react-native implementation pattern 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add baseViewModel?.play() after binding view model instance - Forces view to refresh and show the new binding state - Helps ensure visual updates appear immediately 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add baseViewModel?.play() for .none and .auto cases - Ensures view refreshes when switching to these modes - All binding modes now trigger play() for consistent behavior - Fix prettier formatting in example 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add artboard.viewModelInstance binding in addition to stateMachine - Add view.play() call after all binding mode changes - Matches iOS implementation for consistent behavior - Ensures visual updates appear when switching modes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove in-place configureDataBinding() method - Set needsReload = true and call afterUpdate() when dataBind changes - Matches old rive-react-native pattern for referencedAssets changes - Full reload via setRiveFile() with new binding configuration - iOS keeps play() approach for smoother experience 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove afterUpdate() call from custom setter - React Native automatically calls afterUpdate() after all props update - Prevents potential double-reload issues 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add isFirstConfigure flag to track initial load - Call play(stateMachineName, isStateMachine: true) after reload - Only play on subsequent reloads, not on first configure - Ensures state machine restarts with new binding iOS note: iOS already calls baseViewModel.play() in applyDataBinding() which handles non-first updates through the didSet mechanism 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
0358e2a to
9c39621
Compare
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
HayesGordon
reviewed
Nov 17, 2025
aabde02 to
b3a94ee
Compare
HayesGordon
reviewed
Nov 18, 2025
HayesGordon
previously approved these changes
Nov 18, 2025
Contributor
HayesGordon
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this!
mfazekas
commented
Nov 18, 2025
HayesGordon
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dataBind property to allow binding viewModelInstance in a declarative way.
Usages:
1.) Set and instance => no ref needed
2.) Also accepts by name:
3.) None or Auto for default