feat: add telemetry via sentry #2865

MasterPtato · 2025-09-04T18:56:03Z

No description provided.

vercel · 2025-09-04T18:56:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-site	Ready	Preview	Comment	Sep 8, 2025 9:26pm

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-studio	Ignored	Preview		Sep 8, 2025 9:26pm

claude · 2025-09-04T18:56:21Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

MasterPtato · 2025-09-04T18:56:31Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

fix(ci): get binaries uploading #2866
feat: add telemetry via sentry #2865 👈 (View in Graphite)
fix(tunnel): fix ups race condition #2858 : 1 other dependent PR (#2859 )
fix(universalpubsub): fix pg driver #2857
fix(guard): remove incorrect connectability check #2856
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

pkg-pr-new · 2025-09-04T18:56:55Z

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2865

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2865

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2865

commit: 8cb9c31

graphite-app · 2025-09-04T18:58:13Z

packages/common/telemetry/src/lib.rs

@@ -0,0 +1,39 @@
+use uuid::Uuid;
+
+const SENTRY_URL: &str = "https://7602663e43cb9dee8c42d1e5e70293f8@o4504307129188352.ingest.us.sentry.io/4509962797252608";


Security Concern: The Sentry DSN URL contains an authentication token (7602663e43cb9dee8c42d1e5e70293f8) that's hardcoded in the source code. This creates a security risk as anyone with repository access can view this token.

Recommendation: Move this sensitive credential to a secure configuration mechanism:

Store in environment variables

Use a secrets management system

Add to a configuration file that's excluded from version control

This follows security best practices for credential management and prevents potential misuse of the Sentry instance.

Suggested change

const SENTRY_URL: &str = "https://[email protected].sentry.io/4509962797252608";

const SENTRY_URL: &str = option_env!("SENTRY_DSN").unwrap_or("https://public@sentry.example.com/1");

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-09-04T18:58:15Z

packages/common/api-builder/src/middleware.rs

+			let status = status_code;
+			let group = error.as_ref().map_or("-", |x| &x.group);
+			let code = error.as_ref().map_or("-", |x| &x.code);
+			let meta = error.as_ref().and_then(|x| x.metadata.as_ref()).unwrap_or(&serde_json::Value::Null);
+			let internal = error.as_ref().and_then(|x| x.internal.as_ref()).map_or("-", |x| x.as_ref());
+
 			tracing::error!(
-				status = ?status_code,
-				group = %error.as_ref().map_or("-", |x| &x.group),
-				code = ?error.as_ref().map_or("-", |x| &x.code),
-				meta = %error.as_ref().and_then(|x| x.metadata.as_ref()).unwrap_or(&serde_json::Value::Null),
-				internal = %error.as_ref().and_then(|x| x.internal.as_ref()).map_or("-", |x| x.as_ref()),
+				?status,
+				%group,
+				%code,
+				%meta,
+				%internal,
 				"http server error"
 			);
+
+			sentry::with_scope(
+				|scope| {
+					scope.set_tag("status", status_code);
+					scope.set_tag("group", group);
+					scope.set_tag("code", code);
+					scope.set_tag("meta", meta);
+					scope.set_tag("internal", internal);
+				},
+				|| {
+					sentry::capture_message("http server error", sentry::Level::Error);
+				},
+			);


Consider extracting the error data extraction logic into a helper function. The same pattern appears in both server error handling (lines 131-136) and client error handling (lines 159-163), creating duplication that could lead to inconsistencies if one section is updated but not the other.

A simple function like:

fn extract_error_data(error: &Option<ErrorResponse>) -> (String, String, &serde_json::Value, String) { let group = error.as_ref().map_or("-", |x| &x.group); let code = error.as_ref().map_or("-", |x| &x.code); let meta = error.as_ref().and_then(|x| x.metadata.as_ref()).unwrap_or(&serde_json::Value::Null); let internal = error.as_ref().and_then(|x| x.internal.as_ref()).map_or("-", |x| x.as_ref()); (group.to_string(), code.to_string(), meta, internal.to_string()) }

This would improve maintainability and ensure consistent error data extraction across both error handling paths.

Suggested change

let status = status_code;

let group = error.as_ref().map_or("-", |x| &x.group);

let code = error.as_ref().map_or("-", |x| &x.code);

let meta = error.as_ref().and_then(|x| x.metadata.as_ref()).unwrap_or(&serde_json::Value::Null);

let internal = error.as_ref().and_then(|x| x.internal.as_ref()).map_or("-", |x| x.as_ref());

tracing::error!(

status = ?status_code,

group = %error.as_ref().map_or("-", |x| &x.group),

code = ?error.as_ref().map_or("-", |x| &x.code),

meta = %error.as_ref().and_then(|x| x.metadata.as_ref()).unwrap_or(&serde_json::Value::Null),

internal = %error.as_ref().and_then(|x| x.internal.as_ref()).map_or("-", |x| x.as_ref()),

?status,

%group,

%code,

%meta,

%internal,

"http server error"

);

sentry::with_scope(

|scope| {

scope.set_tag("status", status_code);

scope.set_tag("group", group);

scope.set_tag("code", code);

scope.set_tag("meta", meta);

scope.set_tag("internal", internal);

},

|| {

sentry::capture_message("http server error", sentry::Level::Error);

},

);

let status = status_code;

let (group, code, meta, internal) = extract_error_data(&error);

tracing::error!(

?status,

%group,

%code,

%meta,

%internal,

"http server error"

);

sentry::with_scope(

|scope| {

scope.set_tag("status", status_code);

scope.set_tag("group", &group);

scope.set_tag("code", &code);

scope.set_tag("meta", meta);

scope.set_tag("internal", &internal);

},

|| {

sentry::capture_message("http server error", sentry::Level::Error);

},

);

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-09-04T18:58:17Z

packages/common/api-builder/src/middleware.rs

+					scope.set_tag("status", status_code);
+					scope.set_tag("group", group);
+					scope.set_tag("code", code);
+					scope.set_tag("meta", meta);
+					scope.set_tag("internal", internal);


There appears to be a type inconsistency in how the status code is handled. On line 131, status_code is assigned to variable status, but on line 148, status_code is used directly when setting the Sentry tag.

For proper Sentry tag serialization, consider using the string representation of the status code:

scope.set_tag("status", status.to_string());

This ensures the status code is properly serialized as a string value when sent to Sentry, rather than potentially passing the StatusCode enum directly.

Suggested change

scope.set_tag("status", status_code);

scope.set_tag("group", group);

scope.set_tag("code", code);

scope.set_tag("meta", meta);

scope.set_tag("internal", internal);

scope.set_tag("status", status.to_string());

scope.set_tag("group", group);

scope.set_tag("code", code);

scope.set_tag("meta", meta);

scope.set_tag("internal", internal);

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-09-04T18:58:19Z

packages/common/config/src/config/telemetry.rs

+	fn default() -> Self {
+		// NOTE: Telemetry is opt-out
+		Telemetry { enabled: true }
+	}


Privacy and Security Consideration: The current implementation makes telemetry opt-out rather than opt-in (enabled: true by default). This approach may lead to unintended data collection from users who haven't explicitly consented to telemetry. Consider changing to an opt-in model where enabled defaults to false, requiring users to make a conscious choice to enable data collection. This would better align with privacy best practices and reduce the risk of inadvertent data sharing.

Suggested change

fn default() -> Self {

// NOTE: Telemetry is opt-out

Telemetry { enabled: true }

}

fn default() -> Self {

// NOTE: Telemetry is opt-in

Telemetry { enabled: false }

}

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

claude · 2025-09-04T19:13:48Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

packages/infra/engine/src/main.rs

claude · 2025-09-04T19:22:18Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-04T19:22:24Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

graphite-app · 2025-09-08T21:46:50Z

Merge activity

Sep 8, 9:46 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Sep 8, 9:47 PM UTC: CI is running for this pull request on a draft pull request (#2885) due to your merge queue CI optimization settings.
Sep 8, 9:48 PM UTC: Merged by the Graphite merge queue via draft PR: #2885.

MasterPtato requested a review from NathanFlurry September 4, 2025 18:56

This was referenced Sep 4, 2025

chore(runner): disable default logs #2862

Closed

chore(runner): add ability to disable auto-shutdown #2859

Closed

graphite-app bot reviewed Sep 4, 2025

View reviewed changes

vercel bot deployed to Preview – rivet-site September 4, 2025 18:58 View deployment

MasterPtato force-pushed the 09-04-feat_add_telemetry_via_sentry branch from 7e50154 to 109863b Compare September 4, 2025 19:13

graphite-app bot reviewed Sep 4, 2025

View reviewed changes

packages/infra/engine/src/main.rs Show resolved Hide resolved

vercel bot deployed to Preview – rivet-site September 4, 2025 19:16 View deployment

MasterPtato changed the base branch from 09-02-fix_universalpubsub_fix_pg_driver to graphite-base/2865 September 4, 2025 19:21

MasterPtato force-pushed the 09-04-feat_add_telemetry_via_sentry branch from 109863b to 3bcc74f Compare September 4, 2025 19:22

MasterPtato changed the base branch from graphite-base/2865 to 09-03-fix_tunnel_fix_ups_race_condition September 4, 2025 19:22

vercel bot deployed to Preview – rivet-site September 4, 2025 19:26 View deployment

MasterPtato mentioned this pull request Sep 4, 2025

fix(ci): get binaries uploading #2866

Closed

NathanFlurry mentioned this pull request Sep 5, 2025

chore(runner): connect tunnel before connecting pb ws #2872

Closed

MasterPtato force-pushed the 09-03-fix_tunnel_fix_ups_race_condition branch from 6cf9da6 to 624b560 Compare September 5, 2025 21:14

MasterPtato mentioned this pull request Sep 5, 2025

feat(pegboard): outbound runners #2873

Merged

NathanFlurry changed the base branch from 09-03-fix_tunnel_fix_ups_race_condition to graphite-base/2865 September 5, 2025 21:39

NathanFlurry mentioned this pull request Sep 5, 2025

chore(ups): add message chunking & ups protocol #2874

Closed

vercel bot deployed to Preview – rivet-site September 8, 2025 21:26 View deployment

graphite-app bot pushed a commit that referenced this pull request Sep 8, 2025

feat: add telemetry via sentry (#2865)

8a60a1f

graphite-app bot closed this Sep 8, 2025

graphite-app bot deleted the 09-04-feat_add_telemetry_via_sentry branch September 8, 2025 21:48

github-actions bot mentioned this pull request Sep 8, 2025

chore(main): release 25.6.1 #2851

Merged

MasterPtato mentioned this pull request Sep 9, 2025

fix: configure runner config per runner name #2891

Merged

This was referenced Sep 9, 2025

chore(ups): add postgres auto-reconnect #2892

Merged

chore(ups): handle edge cases with postgres listen/unlisten/notify when disconnected/reconnecting #2893

Closed

ci: switch to depot #2894

Closed

chore(runner): handle async actor stop #2895

Merged

This was referenced Sep 9, 2025

chore: remove port name #2897

Merged

fix(udb): revamp udb api #2898

Merged

This was referenced Sep 12, 2025

fix(epoxy): fix Any quorum type not reaching any node #2910

Merged

chore(util): increase max ident len #2911

Merged

This was referenced Sep 13, 2025

fix(api): fix query serialization for remote req #2909

Merged

chore: cleanup, move ee changes #2901

Merged

fix(epoxy): fix sending msgs to self #2913

Merged

fix(api): fix creating actors in other dcs #2914

Merged

NathanFlurry mentioned this pull request Sep 14, 2025

chore(runner): add alarms api #2919

Merged

jog1t mentioned this pull request Sep 15, 2025

feat(inspector): make inspector compatible with new architecture #2920

Closed

This was referenced Sep 15, 2025

chore: fix api gen #2921

Merged

chore: clean up api-public #2922

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add telemetry via sentry #2865

feat: add telemetry via sentry #2865

Uh oh!

MasterPtato commented Sep 4, 2025

Uh oh!

vercel bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

claude bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

MasterPtato commented Sep 4, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

graphite-app bot Sep 4, 2025

Uh oh!

graphite-app bot Sep 4, 2025

Uh oh!

graphite-app bot Sep 4, 2025

Uh oh!

graphite-app bot Sep 4, 2025

Uh oh!

claude bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

claude bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

claude bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

		@@ -0,0 +1,39 @@
		use uuid::Uuid;

		const SENTRY_URL: &str = "https://7602663e43cb9dee8c42d1e5e70293f8@o4504307129188352.ingest.us.sentry.io/4509962797252608";

	const SENTRY_URL: &str = "https://[email protected].sentry.io/4509962797252608";
	const SENTRY_URL: &str = option_env!("SENTRY_DSN").unwrap_or("https://public@sentry.example.com/1");

feat: add telemetry via sentry #2865

feat: add telemetry via sentry #2865

Uh oh!

Conversation

MasterPtato commented Sep 4, 2025

Uh oh!

vercel bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

pkg-pr-new bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

claude bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

vercel bot commented Sep 4, 2025 •

edited

Loading

claude bot commented Sep 4, 2025 •

edited

Loading

MasterPtato commented Sep 4, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 4, 2025 •

edited

Loading

claude bot commented Sep 4, 2025 •

edited

Loading

claude bot commented Sep 4, 2025 •

edited

Loading

claude bot commented Sep 4, 2025 •

edited

Loading

graphite-app bot commented Sep 8, 2025 •

edited

Loading